[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 3 lines] D1044: [DrKonqi] Reliably quit when closing report assistant
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-02-29 23:00:35
Message-ID: differential-rev-PHID-DREV-5tsaauu45tah3g2sy4df-req () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
broulik added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  The finished signal is not emitted when the dialog is just closed and neither is the reject signal.
  Since the dialog is DeleteOnClose we can just connect to QObject::destroyed

TEST PLAN
  I think there's a better solution but I finally found why I often ended up with a bunch of drkonqis \
still hanging around when I couldnt be bothered to actually finish filing a bug :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1044

AFFECTED FILES
  drkonqi/drkonqidialog.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma
Cc: plasma-devel


[Attachment #5 (text/html)]

<div>broulik created this revision.<br />
broulik added a reviewer: Plasma.<br />
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.<br />
broulik added a project: Plasma.<br />
Herald added a subscriber: plasma-devel.</div><br /><div><strong>REVISION SUMMARY</strong><div><p>The \
finished signal is not emitted when the dialog is just closed and neither is the reject signal.<br /> \
Since the dialog is DeleteOnClose we can just connect to QObject::destroyed</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>I think there&#039;s a better solution but I finally found why I \
often ended up with a bunch of drkonqis still hanging around when I couldnt be bothered to actually \
finish filing a bug :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE \
Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1044" \
rel="noreferrer">https://phabricator.kde.org/D1044</a></div></div><br /><div><strong>AFFECTED \
FILES</strong><div><div>drkonqi/drkonqidialog.cpp</div></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]