From kde-panel-devel  Mon Feb 29 23:00:35 2016
From: "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date: Mon, 29 Feb 2016 23:00:35 +0000
To: kde-panel-devel
Subject: [Differential] [Request, 3 lines] D1044: [DrKonqi] Reliably quit when closing report assistant
Message-Id: <differential-rev-PHID-DREV-5tsaauu45tah3g2sy4df-req () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145678684729222
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============5860758358257579964=="

--===============5860758358257579964==
Content-Type: multipart/alternative; boundary="c9305762e50f4a7ab976189e76171a63"

--c9305762e50f4a7ab976189e76171a63
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
broulik added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  The finished signal is not emitted when the dialog is just closed and neither is the reject signal.
  Since the dialog is DeleteOnClose we can just connect to QObject::destroyed

TEST PLAN
  I think there's a better solution but I finally found why I often ended up with a bunch of drkonqis still hanging around when I couldnt be bothered to actually finish filing a bug :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1044

AFFECTED FILES
  drkonqi/drkonqidialog.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma
Cc: plasma-devel

--c9305762e50f4a7ab976189e76171a63
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<div>broulik=20created=20this=20revision.<br=20/>
broulik=20added=20a=20reviewer:=20Plasma.<br=20/>
broulik=20set=20the=20repository=20for=20this=20revision=20to=20rPLASMAWORK=
SPACE=20Plasma=20Workspace.<br=20/>
broulik=20added=20a=20project:=20Plasma.<br=20/>
Herald=20added=20a=20subscriber:=20plasma-devel.</div><br=20/><div><strong>=
REVISION=20SUMMARY</strong><div><p>The=20finished=20signal=20is=20not=20emi=
tted=20when=20the=20dialog=20is=20just=20closed=20and=20neither=20is=20the=
=20reject=20signal.<br=20/>
Since=20the=20dialog=20is=20DeleteOnClose=20we=20can=20just=20connect=20to=
=20QObject::destroyed</p></div></div><br=20/><div><strong>TEST=20PLAN</stro=
ng><div><p>I=20think=20there&#039;s=20a=20better=20solution=20but=20I=20fin=
ally=20found=20why=20I=20often=20ended=20up=20with=20a=20bunch=20of=20drkon=
qis=20still=20hanging=20around=20when=20I=20couldnt=20be=20bothered=20to=20=
actually=20finish=20filing=20a=20bug=20:)</p></div></div><br=20/><div><stro=
ng>REPOSITORY</strong><div><div>rPLASMAWORKSPACE=20Plasma=20Workspace</div>=
</div></div><br=20/><div><strong>REVISION=20DETAIL</strong><div><a=20href=
=3D"https://phabricator.kde.org/D1044"=20rel=3D"noreferrer">https://phabric=
ator.kde.org/D1044</a></div></div><br=20/><div><strong>AFFECTED=20FILES</st=
rong><div><div>drkonqi/drkonqidialog.cpp</div></div></div><br=20/><div><str=
ong>EMAIL=20PREFERENCES</strong><div><a=20href=3D"https://phabricator.kde.o=
rg/settings/panel/emailpreferences/"=20rel=3D"noreferrer">https://phabricat=
or.kde.org/settings/panel/emailpreferences/</a></div></div><br=20/><div><st=
rong>To:=20</strong>broulik,=20Plasma<br=20/><strong>Cc:=20</strong>plasma-=
devel<br=20/></div>
--c9305762e50f4a7ab976189e76171a63--

--===============5860758358257579964==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl
dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo=

--===============5860758358257579964==--