--===============5860758358257579964== Content-Type: multipart/alternative; boundary="c9305762e50f4a7ab976189e76171a63" --c9305762e50f4a7ab976189e76171a63 Content-Type: text/plain; charset="ascii" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY The finished signal is not emitted when the dialog is just closed and neither is the reject signal. Since the dialog is DeleteOnClose we can just connect to QObject::destroyed TEST PLAN I think there's a better solution but I finally found why I often ended up with a bunch of drkonqis still hanging around when I couldnt be bothered to actually finish filing a bug :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1044 AFFECTED FILES drkonqi/drkonqidialog.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel --c9305762e50f4a7ab976189e76171a63 Content-Type: text/html; charset="ascii" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable
The=20finished=20signal=20is=20not=20emi=
tted=20when=20the=20dialog=20is=20just=20closed=20and=20neither=20is=20the=
=20reject=20signal.
Since=20the=20dialog=20is=20DeleteOnClose=20we=20can=20just=20connect=20to=
=20QObject::destroyed
I=20think=20there's=20a=20better=20solution=20but=20I=20fin= ally=20found=20why=20I=20often=20ended=20up=20with=20a=20bunch=20of=20drkon= qis=20still=20hanging=20around=20when=20I=20couldnt=20be=20bothered=20to=20= actually=20finish=20filing=20a=20bug=20:)