'Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver
From:       "Bhushan Shah" <bhush94 () gmail ! com>
Date:       2015-10-31 12:41:16
Message-ID: 20151031124116.19145.52143 () mimi ! kde ! org
[Download RAW message or body]

--===============1750653540293301758==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125892/
-----------------------------------------------------------

(Updated Oct. 31, 2015, 6:11 p.m.)

Review request for Plasma, David Edmundson and Martin Gräßlin.

Repository: plasma-workspace

Description (updated)
-------

To split libksld it is required that it no longer depends upon ksmserver being parent \
dir.

I am just unsure about removal of,

set(ksmserver_xml  ${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml)
and
qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface)

Diffs
-----

  ksmserver/config-ksmserver.h.cmake f24e62d 
  ksmserver/screenlocker/CMakeLists.txt 4213713 
  ksmserver/screenlocker/autotests/CMakeLists.txt 51eb0fe 
  ksmserver/screenlocker/config-kscreenlocker.h.cmake PRE-CREATION 
  ksmserver/screenlocker/greeter/CMakeLists.txt 942d88c 
  ksmserver/screenlocker/greeter/authenticator.cpp 4d916a1 
  ksmserver/screenlocker/greeter/autotests/CMakeLists.txt 4244a2a 
  ksmserver/screenlocker/waylandserver.cpp f8ef665 
  ksmserver/screenlocker/ksldapp.cpp f062082 
  ksmserver/screenlocker/kcm/kcm.cpp 751b566 
  ksmserver/screenlocker/kcm/CMakeLists.txt c5c62be 
  ksmserver/screenlocker/greeter/autotests/killtest.cpp 363c9f0 

Diff: https://git.reviewboard.kde.org/r/125892/diff/

Testing
-------

builds, installs, tests pass

Thanks,

Bhushan Shah

--===============1750653540293301758==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125892/">https://git.reviewboard.kde.org/r/125892/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, David Edmundson and Martin Gräßlin.</div>
<div>By Bhushan Shah.</div>

<p style="color: grey;"><i>Updated Oct. 31, 2015, 6:11 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">To split libksld it is required that it no longer \
depends upon ksmserver being parent dir.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I am just unsure about \
removal of,</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">set(ksmserver_xml  \
${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml) and
qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface)</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">builds, installs, tests pass</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/config-ksmserver.h.cmake <span style="color: \
grey">(f24e62d)</span></li>

 <li>ksmserver/screenlocker/CMakeLists.txt <span style="color: \
grey">(4213713)</span></li>

 <li>ksmserver/screenlocker/autotests/CMakeLists.txt <span style="color: \
grey">(51eb0fe)</span></li>

 <li>ksmserver/screenlocker/config-kscreenlocker.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: \
grey">(942d88c)</span></li>

 <li>ksmserver/screenlocker/greeter/authenticator.cpp <span style="color: \
grey">(4d916a1)</span></li>

 <li>ksmserver/screenlocker/greeter/autotests/CMakeLists.txt <span style="color: \
grey">(4244a2a)</span></li>

 <li>ksmserver/screenlocker/waylandserver.cpp <span style="color: \
grey">(f8ef665)</span></li>

 <li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(f062082)</span></li>

 <li>ksmserver/screenlocker/kcm/kcm.cpp <span style="color: \
grey">(751b566)</span></li>

 <li>ksmserver/screenlocker/kcm/CMakeLists.txt <span style="color: \
grey">(c5c62be)</span></li>

 <li>ksmserver/screenlocker/greeter/autotests/killtest.cpp <span style="color: \
grey">(363c9f0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125892/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1750653540293301758==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 