From kde-panel-devel Sat Oct 31 12:41:16 2015 From: "Bhushan Shah" Date: Sat, 31 Oct 2015 12:41:16 +0000 To: kde-panel-devel Subject: Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver Message-Id: <20151031124116.19145.52143 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144629529226422 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2304038262155962031==" --===============2304038262155962031== Content-Type: multipart/alternative; boundary="===============1750653540293301758==" --===============1750653540293301758== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125892/ ----------------------------------------------------------- (Updated Oct. 31, 2015, 6:11 p.m.) Review request for Plasma, David Edmundson and Martin Gräßlin. Repository: plasma-workspace Description (updated) ------- To split libksld it is required that it no longer depends upon ksmserver being parent dir. I am just unsure about removal of, set(ksmserver_xml ${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml) and qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface) Diffs ----- ksmserver/config-ksmserver.h.cmake f24e62d ksmserver/screenlocker/CMakeLists.txt 4213713 ksmserver/screenlocker/autotests/CMakeLists.txt 51eb0fe ksmserver/screenlocker/config-kscreenlocker.h.cmake PRE-CREATION ksmserver/screenlocker/greeter/CMakeLists.txt 942d88c ksmserver/screenlocker/greeter/authenticator.cpp 4d916a1 ksmserver/screenlocker/greeter/autotests/CMakeLists.txt 4244a2a ksmserver/screenlocker/waylandserver.cpp f8ef665 ksmserver/screenlocker/ksldapp.cpp f062082 ksmserver/screenlocker/kcm/kcm.cpp 751b566 ksmserver/screenlocker/kcm/CMakeLists.txt c5c62be ksmserver/screenlocker/greeter/autotests/killtest.cpp 363c9f0 Diff: https://git.reviewboard.kde.org/r/125892/diff/ Testing ------- builds, installs, tests pass Thanks, Bhushan Shah --===============1750653540293301758== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125892/

Review request for Plasma, David Edmundson and Martin Gräßlin.
By Bhushan Shah.

Updated Oct. 31, 2015, 6:11 p.m.

Repository: plasma-workspace

Description (updated)

To split libksld it is required that it no longer depends upon ksmserver being parent dir.


I am just unsure about removal of,


set(ksmserver_xml  ${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml)
and
qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface)

Testing 

builds, installs, tests pass

Diffs

  • ksmserver/config-ksmserver.h.cmake (f24e62d)
  • ksmserver/screenlocker/CMakeLists.txt (4213713)
  • ksmserver/screenlocker/autotests/CMakeLists.txt (51eb0fe)
  • ksmserver/screenlocker/config-kscreenlocker.h.cmake (PRE-CREATION)
  • ksmserver/screenlocker/greeter/CMakeLists.txt (942d88c)
  • ksmserver/screenlocker/greeter/authenticator.cpp (4d916a1)
  • ksmserver/screenlocker/greeter/autotests/CMakeLists.txt (4244a2a)
  • ksmserver/screenlocker/waylandserver.cpp (f8ef665)
  • ksmserver/screenlocker/ksldapp.cpp (f062082)
  • ksmserver/screenlocker/kcm/kcm.cpp (751b566)
  • ksmserver/screenlocker/kcm/CMakeLists.txt (c5c62be)
  • ksmserver/screenlocker/greeter/autotests/killtest.cpp (363c9f0)

View Diff
--===============1750653540293301758==-- --===============2304038262155962031== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============2304038262155962031==--