[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125678: Introduce User Switcher plasmoid
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-10-31 13:36:07
Message-ID: 20151031133607.19145.39011 () mimi ! kde ! org
[Download RAW message or body]

--===============8894592435263936543==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125678/
-----------------------------------------------------------

(Updated Oct. 31, 2015, 1:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
-------

Submitted with commit 01824730acc49aea50bc0d0da1eb17b270125458 by Kai Uwe Broulik to \
branch master.


Repository: kdeplasma-addons


Description
-------

It is prety common in other desktop environments to have something that allows \
switching between users and logout/shutdown quickly. It is inspired by the Fast User \
Switch plasmoid from kde-apps.org [1]

[1] http://kde-apps.org/content/show.php?content=127462


Diffs
-----

  applets/CMakeLists.txt 4079726 
  applets/userswitcher/CMakeLists.txt PRE-CREATION 
  applets/userswitcher/Messages.sh PRE-CREATION 
  applets/userswitcher/package/contents/config/config.qml PRE-CREATION 
  applets/userswitcher/package/contents/config/main.xml PRE-CREATION 
  applets/userswitcher/package/contents/ui/ListDelegate.qml PRE-CREATION 
  applets/userswitcher/package/contents/ui/configGeneral.qml PRE-CREATION 
  applets/userswitcher/package/contents/ui/main.qml PRE-CREATION 
  applets/userswitcher/package/metadata.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125678/diff/


Testing
-------

When the applet opens, it updates. It grows a maximum of half the screen height, \
should there be more users currently logged in, the list can be scrolled. Switching \
users works, both with and without locking the screen, depending on user's settings. \
Opening new sessions, locking the screen and shutting down also work.

The applet doesn't have any settings, the label probably needs tweaking so its sizing \
policy is similar to the digital clock so the two look reasonable next to each other.


File Attachments
----------------

Plasmoid in action
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/17/05d93363-9b15-4c77-abe0-6f8ed9b3cab7__userswitcherplasmoid3.png
 Applet in larger panel and desktop
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/19/49290a8d-8ce3-4ab4-89a8-76990ca73084__userswitcherplasmoid4.png
 Applet settings
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/19/704a5450-2aa9-4250-92a8-6deed29ac859__userswitcherplasmoid5.png



Thanks,

Kai Uwe Broulik


--===============8894592435263936543==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125678/">https://git.reviewboard.kde.org/r/125678/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>


<p style="color: grey;"><i>Updated Oct. 31, 2015, 1:36 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 01824730acc49aea50bc0d0da1eb17b270125458 by Kai \
Uwe Broulik to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It is prety common in other desktop environments to \
have something that allows switching between users and logout/shutdown quickly. It is \
inspired by the Fast User Switch plasmoid from kde-apps.org [1]</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">[1] http://kde-apps.org/content/show.php?content=127462</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When the applet opens, it updates. It grows a maximum \
of half the screen height, should there be more users currently logged in, the list \
can be scrolled. Switching users works, both with and without locking the screen, \
depending on user's settings. Opening new sessions, locking the screen and shutting \
down also work.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The applet doesn't have any settings, \
the label probably needs tweaking so its sizing policy is similar to the digital \
clock so the two look reasonable next to each other.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/CMakeLists.txt <span style="color: grey">(4079726)</span></li>

 <li>applets/userswitcher/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/userswitcher/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/userswitcher/package/contents/config/config.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/userswitcher/package/contents/config/main.xml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/userswitcher/package/contents/ui/ListDelegate.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/userswitcher/package/contents/ui/configGeneral.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/userswitcher/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/userswitcher/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125678/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/17/05d93363-9b15-4c77-abe0-6f8ed9b3cab7__userswitcherplasmoid3.png">Plasmoid \
in action</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/19/49290a8d-8ce3-4ab4-89a8-76990ca73084__userswitcherplasmoid4.png">Applet \
in larger panel and desktop</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/19/704a5450-2aa9-4250-92a8-6deed29ac859__userswitcherplasmoid5.png">Applet \
settings</a></li>

</ul>




  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============8894592435263936543==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic