'Re: Review Request 125851: [kscreenlocker] Remove KWorkspace dependency'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125851: [kscreenlocker] Remove KWorkspace dependency
From:       "Bhushan Shah" <bhush94 () gmail ! com>
Date:       2015-10-30 12:11:37
Message-ID: 20151030121137.14097.29402 () mimi ! kde ! org
[Download RAW message or body]

--===============1810573177282319076==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Oct. 29, 2015, 2:20 p.m., Martin Gräßlin wrote:
> > Ship It!

Submitted in http://commits.kde.org/plasma-workspace/ab258330725cc03af3a90c721e3dc684864d8cf1 \
on behalf of Kai, though forgot review:

- Bhushan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125851/#review87651
-----------------------------------------------------------

On Oct. 29, 2015, 2:31 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125851/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 2:31 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Removes the sessions stuff
> 
> 
> Diffs
> -----
> 
> ksmserver/screenlocker/greeter/CMakeLists.txt e6768f0 
> ksmserver/screenlocker/greeter/greeterapp.cpp a88b61a 
> ksmserver/screenlocker/greeter/sessions.h 8a4c042 
> ksmserver/screenlocker/greeter/sessions.cpp 5f831d5 
> 
> Diff: https://git.reviewboard.kde.org/r/125851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============1810573177282319076==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125851/">https://git.reviewboard.kde.org/r/125851/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 29th, 2015, 2:20 p.m. IST, <b>Martin \
Gräßlin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Submitted in \
http://commits.kde.org/plasma-workspace/ab258330725cc03af3a90c721e3dc684864d8cf1 on \
behalf of Kai, though forgot review:</p></pre> <br />

<p>- Bhushan</p>

<br />
<p>On October 29th, 2015, 2:31 a.m. IST, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Oct. 29, 2015, 2:31 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Removes the sessions stuff</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: \
grey">(e6768f0)</span></li>

 <li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(a88b61a)</span></li>

 <li>ksmserver/screenlocker/greeter/sessions.h <span style="color: \
grey">(8a4c042)</span></li>

 <li>ksmserver/screenlocker/greeter/sessions.cpp <span style="color: \
grey">(5f831d5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125851/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1810573177282319076==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 