From kde-panel-devel Mon Aug 31 11:01:26 2015 From: "Andriy Gapon" Date: Mon, 31 Aug 2015 11:01:26 +0000 To: kde-panel-devel Subject: Re: Review Request 105112: kickoff: save recent applications list on every change to it Message-Id: <20150831110126.10622.38846 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144101891224414 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5380761411255774343==" --===============5380761411255774343== Content-Type: multipart/alternative; boundary="===============0071923908956868956==" --===============0071923908956868956== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105112/ ----------------------------------------------------------- (Updated Aug. 31, 2015, 11:01 a.m.) Status ------ This change has been discarded. Review request for Plasma and Torrie Fischer. Bugs: 206511 http://bugs.kde.org/show_bug.cgi?id=206511 Repository: kde-workspace Description ------- Currently recent applications list in kickoff is saved only when kickoff gracefully exits. This could be a minor annoyance when X/KDE/plasma crashes. I think that saving the list on every update to it should be a good idea. It should be a low overhead too, because the list changes only when a user launches an application via KDE. Diffs ----- plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e05389 Diff: https://git.reviewboard.kde.org/r/105112/diff/ Testing ------- Thanks, Andriy Gapon --===============0071923908956868956== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105112/

This change has been discarded.

Review request for Plasma and Torrie Fischer.

By Andriy Gapon.

Updated Aug. 31, 2015, 11:01 a.m.

Bugs: 206511

Repository: kde-workspace

Description

Currently recent applications list in kickoff is saved only when kickoff gracefully exits.  This could be a minor annoyance when X/KDE/plasma crashes.  I think that saving the list on every update to it should be a good idea.  It should be a low overhead too, because the list changes only when a user launches an application via KDE.

Diffs

plasma/desktop/applets/kickoff/core/recentapplications.cpp (3e05389)

View Diff

--===============0071923908956868956==-- --===============5380761411255774343== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5380761411255774343==--