'Re: Review Request 124171: Fix applying user settings at login'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124171: Fix applying user settings at login
From:       "Wolfgang Bauer" <wbauer () tmo ! at>
Date:       2015-06-26 11:32:05
Message-ID: 20150626113205.20764.71304 () mimi ! kde ! org
[Download RAW message or body]

--===============9165406611084184698==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124171/
-----------------------------------------------------------

(Updated June 26, 2015, 11:32 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and David Edmundson.

Changes
-------

Submitted with commit 6663ebc14dd9b14f41498c617157e2f059165734 by Wolfgang Bauer to \
branch frameworks.

Bugs: 218668
    http://bugs.kde.org/show_bug.cgi?id=218668

Repository: kgamma

Description
-------

This fixes applying KGamma's user settings at login.
It changes two things:
- export kcminit_kgamma() again, this is necessary so that kcminit can call that \
                function to apply the settings
- add "X-KDE-Init-Phase=0" to the .desktop file, which is apparently needed since \
Plasma 5.3 to make it being called at login

Diffs
-----

  kcmkgamma/kgamma.cpp 7393cf6 
  kcmkgamma/kgamma.desktop b8bac5e 

Diff: https://git.reviewboard.kde.org/r/124171/diff/

Testing
-------

Change the Gamma settings and logout/login.
The settings are now applied again during login, whereas they weren't before.

Thanks,

Wolfgang Bauer

--===============9165406611084184698==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124171/">https://git.reviewboard.kde.org/r/124171/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and David Edmundson.</div>
<div>By Wolfgang Bauer.</div>

<p style="color: grey;"><i>Updated June 26, 2015, 11:32 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 6663ebc14dd9b14f41498c617157e2f059165734 by \
Wolfgang Bauer to branch frameworks.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=218668">218668</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kgamma
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes applying KGamma's user settings at login. \
                It changes two things:
- export kcminit_kgamma() again, this is necessary so that kcminit can call that \
                function to apply the settings
- add "X-KDE-Init-Phase=0" to the .desktop file, which is apparently needed since \
Plasma 5.3 to make it being called at login</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Change the Gamma settings and logout/login. The \
settings are now applied again during login, whereas they weren't before.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcmkgamma/kgamma.cpp <span style="color: grey">(7393cf6)</span></li>

 <li>kcmkgamma/kgamma.desktop <span style="color: grey">(b8bac5e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124171/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9165406611084184698==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 