[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124172: Fix touchpad backend initialization
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-06-26 5:45:22
Message-ID: 20150626054522.20764.89703 () mimi ! kde ! org
[Download RAW message or body]
--===============5647562719635148816==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124172/#review81767
-----------------------------------------------------------
logic seems ok to me, I haven't tested of course.
And don't worry about having missed the 5.3.2 release - it's introducing new \
translations, so it was a no-go for the branch anyway.
kcms/touchpad/src/backends/x11/xlibbackend.cpp (line 281)
<https://git.reviewboard.kde.org/r/124172/#comment56085>
please use i18nc - I think translators have a hard problem understanding how they \
need to translate "Libinput" and "Synaptics" otherwise.
- Martin Gräßlin
On June 25, 2015, 10:50 p.m., Rajeesh K Nambiar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124172/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 10:50 p.m.)
>
>
> Review request for Plasma and Martin Gräßlin.
>
>
> Bugs: 344958
> https://bugs.kde.org/show_bug.cgi?id=344958
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> kcm_touchpad supports both libinput and synaptics backends, but with libinput \
> driver is uninstalled and synaptics driver installed, users get error 'No touchpad \
> found'. Also see Fedora bug https://bugzilla.redhat.com/show_bug.cgi?id=1199825
>
> This missed 5.3.2 by a whisker :-(
>
>
> Diffs
> -----
>
> kcms/touchpad/src/backends/x11/xlibbackend.cpp 2acb162
>
> Diff: https://git.reviewboard.kde.org/r/124172/diff/
>
>
> Testing
> -------
>
> Built Fedora 22 RPMS, locally tested.
>
>
> Thanks,
>
> Rajeesh K Nambiar
>
>
--===============5647562719635148816==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124172/">https://git.reviewboard.kde.org/r/124172/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">logic \
seems ok to me, I haven't tested of course.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">And don't worry about \
having missed the 5.3.2 release - it's introducing new translations, so it was a \
no-go for the branch anyway.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124172/diff/1/?file=381320#file381320line281" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcms/touchpad/src/backends/x11/xlibbackend.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">XlibLibinputBackend::XlibLibinputBackend(QObject *parent) :</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">281</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_errorString</span> <span class="o">=</span> <span \
class="n">i18n</span><span class="p">(</span><span class="s">"Libinput backend \
not found"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">please use i18nc - I think translators have a hard problem understanding \
how they need to translate "Libinput" and "Synaptics" otherwise.</p></pre> </div>
</div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On June 25th, 2015, 10:50 p.m. CEST, Rajeesh K Nambiar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Rajeesh K Nambiar.</div>
<p style="color: grey;"><i>Updated June 25, 2015, 10:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=344958">344958</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">kcm_touchpad supports both libinput and synaptics \
backends, but with libinput driver is uninstalled and synaptics driver installed, \
users get error 'No touchpad found'. Also see Fedora bug \
https://bugzilla.redhat.com/show_bug.cgi?id=1199825</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
missed 5.3.2 by a whisker :-(</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built Fedora 22 RPMS, locally tested.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/touchpad/src/backends/x11/xlibbackend.cpp <span style="color: \
grey">(2acb162)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124172/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5647562719635148816==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic