[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124171: Fix applying user settings at login
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-06-25 21:18:02
Message-ID: 20150625211802.20764.20537 () mimi ! kde ! org
[Download RAW message or body]
--===============7235123739244080347==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124171/#review81757
-----------------------------------------------------------
Ship it!
Thanks for taking care of this.
- David Edmundson
On June 25, 2015, 9:17 p.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124171/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 9:17 p.m.)
>
>
> Review request for Plasma and David Edmundson.
>
>
> Bugs: 218668
> http://bugs.kde.org/show_bug.cgi?id=218668
>
>
> Repository: kgamma
>
>
> Description
> -------
>
> This fixes applying KGamma's user settings at login.
> It changes two things:
> - export kcminit_kgamma() again, this is necessary so that kcminit can call that \
> function to apply the settings
> - add "X-KDE-Init-Phase=0" to the .desktop file, which is apparently needed since \
> Plasma 5.3 to make it being called at login
>
> Diffs
> -----
>
> kcmkgamma/kgamma.cpp 7393cf6
> kcmkgamma/kgamma.desktop b8bac5e
>
> Diff: https://git.reviewboard.kde.org/r/124171/diff/
>
>
> Testing
> -------
>
> Change the Gamma settings and logout/login.
> The settings are now applied again during login, whereas they weren't before.
>
>
> Thanks,
>
> Wolfgang Bauer
>
>
--===============7235123739244080347==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124171/">https://git.reviewboard.kde.org/r/124171/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks for taking care of this.</p></pre> <br />
<p>- David Edmundson</p>
<br />
<p>On June 25th, 2015, 9:17 p.m. UTC, Wolfgang Bauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated June 25, 2015, 9:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=218668">218668</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgamma
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes applying KGamma's user settings at login. \
It changes two things:
- export kcminit_kgamma() again, this is necessary so that kcminit can call that \
function to apply the settings
- add "X-KDE-Init-Phase=0" to the .desktop file, which is apparently needed since \
Plasma 5.3 to make it being called at login</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Change the Gamma settings and logout/login. The \
settings are now applied again during login, whereas they weren't before.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcmkgamma/kgamma.cpp <span style="color: grey">(7393cf6)</span></li>
<li>kcmkgamma/kgamma.desktop <span style="color: grey">(b8bac5e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124171/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7235123739244080347==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic