[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124112: Implement drag and drop for Trash applet
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-06-17 20:47:03
Message-ID: 20150617204703.14517.4888 () mimi ! kde ! org
[Download RAW message or body]
--===============4771344578854328739==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Juni 17, 2015, 7:36 nachm., Sebastian Kügler wrote:
> > applets/trash/plugin/trashplugin.cpp, line 30
> > <https://git.reviewboard.kde.org/r/124112/diff/2/?file=380371#file380371line30>
> >
> > I think we still want to delete this one *somewhere*?
From the documentation:
NOTE: A QObject singleton type instance returned from a singleton type provider is \
owned by the QML engine.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124112/#review81537
-----------------------------------------------------------
On Juni 17, 2015, 4:24 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124112/
> -----------------------------------------------------------
>
> (Updated Juni 17, 2015, 4:24 nachm.)
>
>
> Review request for Plasma.
>
>
> Bugs: 348378
> https://bugs.kde.org/show_bug.cgi?id=348378
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> This allows to drag files onto the trash applet to trash them.
> Also, the code is cleaned up a bit and it is given a sensible minimum size (so the \
> label always fits) as well as the query dialog has been replaced by the standard \
> KIO dialog.
>
> Diffs
> -----
>
> applets/trash/package/contents/ui/main.qml 7715439
> applets/trash/plugin/CMakeLists.txt 9012e66
> applets/trash/plugin/trash.h PRE-CREATION
> applets/trash/plugin/trash.cpp PRE-CREATION
> applets/trash/plugin/trashplugin.cpp 7e866a9
>
> Diff: https://git.reviewboard.kde.org/r/124112/diff/
>
>
> Testing
> -------
>
> Trashed one or multiple files on both desktop and panel.
> When I dismiss the message box, however, Plasma will create an applet for the file \
> dragged. How can I tell it I accepted the drop? Also, it crashes in \
> Client::~Client() () from /usr/lib/x86_64-linux-gnu/libQPulseAudioPrivate.so at \
> times after dismissing the dialog.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============4771344578854328739==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124112/">https://git.reviewboard.kde.org/r/124112/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Juni 17th, 2015, 7:36 nachm. UTC, <b>Sebastian \
Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124112/diff/2/?file=380371#file380371line30" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/trash/plugin/trashplugin.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">30</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="k">new</span> <span class="n">Trash</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think we still want to delete this one <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: \
normal;">somewhere</em>?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">From the documentation:
NOTE: A QObject singleton type instance returned from a singleton type provider is \
owned by the QML engine.</p></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On Juni 17th, 2015, 4:24 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Juni 17, 2015, 4:24 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=348378">348378</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This allows to drag files onto the trash applet to \
trash them. Also, the code is cleaned up a bit and it is given a sensible minimum \
size (so the label always fits) as well as the query dialog has been replaced by the \
standard KIO dialog.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Trashed one or multiple files on both desktop and \
panel. When I dismiss the message box, however, Plasma will create an applet for the \
file dragged. How can I tell it I accepted the drop? Also, it crashes in \
Client::~Client() () from /usr/lib/x86_64-linux-gnu/libQPulseAudioPrivate.so at times \
after dismissing the dialog.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/trash/package/contents/ui/main.qml <span style="color: \
grey">(7715439)</span></li>
<li>applets/trash/plugin/CMakeLists.txt <span style="color: \
grey">(9012e66)</span></li>
<li>applets/trash/plugin/trash.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/trash/plugin/trash.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/trash/plugin/trashplugin.cpp <span style="color: \
grey">(7e866a9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124112/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4771344578854328739==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic