'Re: Review Request 124112: Implement drag and drop for Trash applet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124112: Implement drag and drop for Trash applet
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-06-18 23:46:51
Message-ID: 20150618234651.14517.28831 () mimi ! kde ! org
[Download RAW message or body]

--===============8482781794688664565==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124112/#review81564
-----------------------------------------------------------

Ship it!

Ship It!

- Marco Martin

On June 17, 2015, 4:24 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124112/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 4:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348378
> https://bugs.kde.org/show_bug.cgi?id=348378
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This allows to drag files onto the trash applet to trash them.
> Also, the code is cleaned up a bit and it is given a sensible minimum size (so the \
> label always fits) as well as the query dialog has been replaced by the standard \
> KIO dialog. 
> 
> Diffs
> -----
> 
> applets/trash/package/contents/ui/main.qml 7715439 
> applets/trash/plugin/CMakeLists.txt 9012e66 
> applets/trash/plugin/trash.h PRE-CREATION 
> applets/trash/plugin/trash.cpp PRE-CREATION 
> applets/trash/plugin/trashplugin.cpp 7e866a9 
> 
> Diff: https://git.reviewboard.kde.org/r/124112/diff/
> 
> 
> Testing
> -------
> 
> Trashed one or multiple files on both desktop and panel.
> When I dismiss the message box, however, Plasma will create an applet for the file \
> dragged. How can I tell it I accepted the drop? Also, it crashes in \
> Client::~Client() () from /usr/lib/x86_64-linux-gnu/libQPulseAudioPrivate.so at \
> times after dismissing the dialog. 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============8482781794688664565==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124112/">https://git.reviewboard.kde.org/r/124112/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On June 17th, 2015, 4:24 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated June 17, 2015, 4:24 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=348378">348378</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This allows to drag files onto the trash applet to \
trash them. Also, the code is cleaned up a bit and it is given a sensible minimum \
size (so the label always fits) as well as the query dialog has been replaced by the \
standard KIO dialog.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Trashed one or multiple files on both desktop and \
panel. When I dismiss the message box, however, Plasma will create an applet for the \
file dragged. How can I tell it I accepted the drop? Also, it crashes in \
Client::~Client() () from /usr/lib/x86_64-linux-gnu/libQPulseAudioPrivate.so at times \
after dismissing the dialog.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/trash/package/contents/ui/main.qml <span style="color: \
grey">(7715439)</span></li>

 <li>applets/trash/plugin/CMakeLists.txt <span style="color: \
grey">(9012e66)</span></li>

 <li>applets/trash/plugin/trash.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/trash/plugin/trash.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/trash/plugin/trashplugin.cpp <span style="color: \
grey">(7e866a9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124112/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8482781794688664565==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 