[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124112: Implement drag and drop for Trash applet
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2015-06-17 19:36:13
Message-ID: 20150617193613.14517.82493 () mimi ! kde ! org
[Download RAW message or body]
--===============1213034924303160620==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124112/#review81537
-----------------------------------------------------------
QFile::isWritable() is confusing, it falls back to QIODevice::isWritable(), which \
tells you whether the object is /opened for writing/, not if you're allowed to write. \
The right API to use here is QFileInfo::isWritable(), which should do the right \
thing.
applets/trash/package/contents/ui/main.qml (line 116)
<https://git.reviewboard.kde.org/r/124112/#comment55887>
minor one, but please add spaces around the ==
applets/trash/package/contents/ui/main.qml (line 125)
<https://git.reviewboard.kde.org/r/124112/#comment55888>
spaces around comparison ops
applets/trash/plugin/trashplugin.cpp (line 30)
<https://git.reviewboard.kde.org/r/124112/#comment55889>
I think we still want to delete this one *somewhere*?
ou a
- Sebastian Kügler
On June 17, 2015, 4:24 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124112/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 4:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 348378
> https://bugs.kde.org/show_bug.cgi?id=348378
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> This allows to drag files onto the trash applet to trash them.
> Also, the code is cleaned up a bit and it is given a sensible minimum size (so the \
> label always fits) as well as the query dialog has been replaced by the standard \
> KIO dialog.
>
> Diffs
> -----
>
> applets/trash/package/contents/ui/main.qml 7715439
> applets/trash/plugin/CMakeLists.txt 9012e66
> applets/trash/plugin/trash.h PRE-CREATION
> applets/trash/plugin/trash.cpp PRE-CREATION
> applets/trash/plugin/trashplugin.cpp 7e866a9
>
> Diff: https://git.reviewboard.kde.org/r/124112/diff/
>
>
> Testing
> -------
>
> Trashed one or multiple files on both desktop and panel.
> When I dismiss the message box, however, Plasma will create an applet for the file \
> dragged. How can I tell it I accepted the drop? Also, it crashes in \
> Client::~Client() () from /usr/lib/x86_64-linux-gnu/libQPulseAudioPrivate.so at \
> times after dismissing the dialog.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============1213034924303160620==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124112/">https://git.reviewboard.kde.org/r/124112/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">QFile::isWritable() is confusing, it falls back to QIODevice::isWritable(), \
which tells you whether the object is /opened for writing/, not if you're allowed to \
write. The right API to use here is QFileInfo::isWritable(), which should do the \
right thing.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124112/diff/2/?file=380367#file380367line124" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/trash/package/contents/ui/main.qml</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">116</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">text:</span> <span class="p">(</span><span class="nx">dirModel</span><span \
class="p">.</span><span class="nx">count</span><span class="o">==</span><span \
class="mi">0</span><span class="p">)</span> <span class="o">?</span> <span \
class="nx">i18n</span><span class="p">(</span><span \
class="s2">"Trash\nEmpty"</span><span class="p">)</span><span \
class="o">:</span> <span class="nx">i18np</span><span class="p">(</span><span \
class="s2">"Trash\nOne item"</span><span class="p">,</span> <span \
class="s2">"Trash\n %1 items"</span><span class="p">,</span> <span \
class="nx">dirModel</span><span class="p">.</span><span class="nx">count</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">minor \
one, but please add spaces around the ==</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124112/diff/2/?file=380367#file380367line133" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/trash/package/contents/ui/main.qml</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">85</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">subText:</span> <span class="p">(</span><span \
class="nx">dirModel</span><span class="p">.</span><span class="nx">count</span><span \
class="o">==</span><span class="mi">0</span><span class="p">)</span> <span \
class="o">?</span> <span class="nx">i18n</span><span class="p">(</span><span \
class="s2">"<span class="hl">Trash \n </span>Empty"</span><span \
class="p">)</span><span class="o">:</span> <span class="nx">i18np</span><span \
class="p">(</span><span class="s2">"<span class="hl">Trash\n</span>One \
item"</span><span class="p">,</span> <span class="s2">"<span \
class="hl">Trash\n </span>%1 items"</span><span class="p">,</span> <span \
class="nx">dirModel</span><span class="p">.</span><span class="nx">count</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">125</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">subText:</span> <span \
class="p">(</span><span class="nx">dirModel</span><span class="p">.</span><span \
class="nx">count</span><span class="o">==</span><span class="mi">0</span><span \
class="p">)</span> <span class="o">?</span> <span class="nx">i18n</span><span \
class="p">(</span><span class="s2">"Empty"</span><span class="p">)</span> \
<span class="o">:</span> <span class="nx">i18np</span><span class="p">(</span><span \
class="s2">"One item"</span><span class="p">,</span> <span \
class="s2">"%1 items"</span><span class="p">,</span> <span \
class="nx">dirModel</span><span class="p">.</span><span class="nx">count</span> <span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">spaces around comparison ops</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124112/diff/2/?file=380371#file380371line30" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/trash/plugin/trashplugin.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">30</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="k">new</span> <span class="n">Trash</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think we still want to delete this one <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: \
normal;">somewhere</em>?</p></pre> </div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ou \
a</p></pre>
<p>- Sebastian Kügler</p>
<br />
<p>On June 17th, 2015, 4:24 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated June 17, 2015, 4:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=348378">348378</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This allows to drag files onto the trash applet to \
trash them. Also, the code is cleaned up a bit and it is given a sensible minimum \
size (so the label always fits) as well as the query dialog has been replaced by the \
standard KIO dialog.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Trashed one or multiple files on both desktop and \
panel. When I dismiss the message box, however, Plasma will create an applet for the \
file dragged. How can I tell it I accepted the drop? Also, it crashes in \
Client::~Client() () from /usr/lib/x86_64-linux-gnu/libQPulseAudioPrivate.so at times \
after dismissing the dialog.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/trash/package/contents/ui/main.qml <span style="color: \
grey">(7715439)</span></li>
<li>applets/trash/plugin/CMakeLists.txt <span style="color: \
grey">(9012e66)</span></li>
<li>applets/trash/plugin/trash.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/trash/plugin/trash.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/trash/plugin/trashplugin.cpp <span style="color: \
grey">(7e866a9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124112/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1213034924303160620==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic