'Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.
From:       "Yoann Laissus" <yoann.laissus () gmail ! com>
Date:       2015-05-30 14:12:47
Message-ID: 20150530141247.31615.6969 () mimi ! kde ! org
[Download RAW message or body]

--===============3282079035267904630==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123884/
-----------------------------------------------------------

(Updated May 30, 2015, 2:12 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 1f9c20e4c4c25f5df3593792f5166af3eeee6068 by Yoann Laissus to \
branch Plasma/5.3.

Repository: plasma-desktop

Description
-------

Currently, when the desktop is configured with "Folder view" mode, it uses the whole \
screen, no matter if there are panels in the area. This patch resizes the folder view \
to the available space to avoid overlaps with panels.

Diffs
-----

  containments/desktop/package/contents/ui/FolderViewLayer.qml \
19495b4df4afec18bc90de60ba11eb60b90c52a5   \
containments/desktop/package/contents/ui/main.qml \
c546236abf6376963180ffec648d412bcd6e40db 

Diff: https://git.reviewboard.kde.org/r/123884/diff/

Testing
-------

Tested with panels on each screen side

File Attachments
----------------

Without the patch
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/0572c44b-1f06-46ab-86ad-9aa626c0dc2b__with_overlap.jpg
 With the patch
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg

Thanks,

Yoann Laissus

--===============3282079035267904630==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123884/">https://git.reviewboard.kde.org/r/123884/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>

<p style="color: grey;"><i>Updated May 30, 2015, 2:12 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 1f9c20e4c4c25f5df3593792f5166af3eeee6068 by Yoann \
Laissus to branch Plasma/5.3.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently, when the desktop is configured with "Folder \
view" mode, it uses the whole screen, no matter if there are panels in the area. This \
patch resizes the folder view to the available space to avoid overlaps with \
panels.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with panels on each screen side</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>containments/desktop/package/contents/ui/FolderViewLayer.qml <span style="color: \
grey">(19495b4df4afec18bc90de60ba11eb60b90c52a5)</span></li>

 <li>containments/desktop/package/contents/ui/main.qml <span style="color: \
grey">(c546236abf6376963180ffec648d412bcd6e40db)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123884/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/0572c44b-1f06-46ab-86ad-9aa626c0dc2b__with_overlap.jpg">Without \
the patch</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg">With \
the patch</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3282079035267904630==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 