[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123815: Fix the panel configuration width in case of long strings in buttons.
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-05-30 13:04:12
Message-ID: 20150530130412.31615.40765 () mimi ! kde ! org
[Download RAW message or body]
--===============8144303255942246231==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On May 17, 2015, 11:33 a.m., David Edmundson wrote:
> > Nice work, thanks.
>
> Yoann Laissus wrote:
> A little late for the 5.3.1 but do I need to backport the patch to the 5.3 branch ?
>
> David Edmundson wrote:
> If you want it in 5.3.2, yes.
>
> In general it's a combo of 3 factors:
> - how much effort is it to backport
> - is it likely to break something
> - how big of a probelm is the bug
>
> In this case I think it makes sense.
>
> Do you know how to do it?
>
> Yoann Laissus wrote:
> Hum, as I already commited in master, I would say a cherry-pick ?
> Otherwise, I would have commited in 5.3 and then merge in master.
Yes, absolutely right.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123815/#review80514
-----------------------------------------------------------
On May 17, 2015, 1:23 p.m., Yoann Laissus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123815/
> -----------------------------------------------------------
>
> (Updated May 17, 2015, 1:23 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> The panel configuration width is defined to a fixed value when it's vertical.
> In English, it's not a problem because strings are very compacts. But for example, \
> in French, some strings get too big for the buttons.
> The width is now computed dynamically from the button layout.
> I'm really not a QML expert, please let me know if there is a better way to achieve \
> that.
>
> Diffs
> -----
>
> desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml \
> 7cf567e30c99b38e6fbdfa718e4de2ef32c2f5dd
> Diff: https://git.reviewboard.kde.org/r/123815/diff/
>
>
> Testing
> -------
>
> Tested in all screen edges.
>
>
> File Attachments
> ----------------
>
> Truncated text
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/d04883f4-e479-4e0c-9c49-fb545003ab9d__truncated_button.jpg
> After the fix
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/60e37174-5523-4682-aabb-fc0e23ac5bdc__fixed_button.jpg
>
>
> Thanks,
>
> Yoann Laissus
>
>
--===============8144303255942246231==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123815/">https://git.reviewboard.kde.org/r/123815/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 17th, 2015, 11:33 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Nice work, thanks.</p></pre> </blockquote>
<p>On May 27th, 2015, 8:12 p.m. UTC, <b>Yoann Laissus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A \
little late for the 5.3.1 but do I need to backport the patch to the 5.3 branch \
?</p></pre> </blockquote>
<p>On May 27th, 2015, 10:33 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
you want it in 5.3.2, yes.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">In general it's a combo \
of 3 factors:
- how much effort is it to backport
- is it likely to break something
- how big of a probelm is the bug</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In this case I think it makes sense.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Do you know how to do it?</p></pre> </blockquote>
<p>On May 30th, 2015, 10:24 a.m. UTC, <b>Yoann Laissus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hum, \
as I already commited in master, I would say a cherry-pick ? Otherwise, I would have \
commited in 5.3 and then merge in master.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
absolutely right.</p></pre> <br />
<p>- David</p>
<br />
<p>On May 17th, 2015, 1:23 p.m. UTC, Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated May 17, 2015, 1:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The panel configuration width is defined to a fixed \
value when it's vertical. In English, it's not a problem because strings are very \
compacts. But for example, in French, some strings get too big for the buttons.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The width is now computed dynamically from the button \
layout. I'm really not a QML expert, please let me know if there is a better way to \
achieve that.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested in all screen edges.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml <span \
style="color: grey">(7cf567e30c99b38e6fbdfa718e4de2ef32c2f5dd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123815/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/d04883f4-e479-4e0c-9c49-fb545003ab9d__truncated_button.jpg">Truncated \
text</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/60e37174-5523-4682-aabb-fc0e23ac5bdc__fixed_button.jpg">After \
the fix</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8144303255942246231==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic