From kde-panel-devel Sat May 30 14:12:47 2015 From: "Yoann Laissus" Date: Sat, 30 May 2015 14:12:47 +0000 To: kde-panel-devel Subject: Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels. Message-Id: <20150530141247.31615.6969 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143299518914953 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1362053114543006331==" --===============1362053114543006331== Content-Type: multipart/alternative; boundary="===============3282079035267904630==" --===============3282079035267904630== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123884/ ----------------------------------------------------------- (Updated May 30, 2015, 2:12 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit 1f9c20e4c4c25f5df3593792f5166af3eeee6068 by Yoann Laissus to branch Plasma/5.3. Repository: plasma-desktop Description ------- Currently, when the desktop is configured with "Folder view" mode, it uses the whole screen, no matter if there are panels in the area. This patch resizes the folder view to the available space to avoid overlaps with panels. Diffs ----- containments/desktop/package/contents/ui/FolderViewLayer.qml 19495b4df4afec18bc90de60ba11eb60b90c52a5 containments/desktop/package/contents/ui/main.qml c546236abf6376963180ffec648d412bcd6e40db Diff: https://git.reviewboard.kde.org/r/123884/diff/ Testing ------- Tested with panels on each screen side File Attachments ---------------- Without the patch https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/0572c44b-1f06-46ab-86ad-9aa626c0dc2b__with_overlap.jpg With the patch https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg Thanks, Yoann Laissus --===============3282079035267904630== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123884/

This change has been marked as submitted.

Review request for Plasma.
By Yoann Laissus.

Updated May 30, 2015, 2:12 p.m.

Changes

Submitted with commit 1f9c20e4c4c25f5df3593792f5166af3eeee6068 by Yoann Laissus to branch Plasma/5.3.
Repository: plasma-desktop

Description 

Currently, when the desktop is configured with "Folder view" mode, it uses the whole screen, no matter if there are panels in the area.
This patch resizes the folder view to the available space to avoid overlaps with panels.

Testing 

Tested with panels on each screen side

Diffs

  • containments/desktop/package/contents/ui/FolderViewLayer.qml (19495b4df4afec18bc90de60ba11eb60b90c52a5)
  • containments/desktop/package/contents/ui/main.qml (c546236abf6376963180ffec648d412bcd6e40db)

View Diff

File Attachments

  • Without the patch
  • With the patch
    		•
    --===============3282079035267904630==-- --===============1362053114543006331== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1362053114543006331==--