--===============7755468900377667263== Content-Type: multipart/alternative; boundary="===============8144303255942246231==" --===============8144303255942246231== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 17, 2015, 11:33 a.m., David Edmundson wrote: > > Nice work, thanks. > > Yoann Laissus wrote: > A little late for the 5.3.1 but do I need to backport the patch to the 5.3 branch ? > > David Edmundson wrote: > If you want it in 5.3.2, yes. > > In general it's a combo of 3 factors: > - how much effort is it to backport > - is it likely to break something > - how big of a probelm is the bug > > In this case I think it makes sense. > > Do you know how to do it? > > Yoann Laissus wrote: > Hum, as I already commited in master, I would say a cherry-pick ? > Otherwise, I would have commited in 5.3 and then merge in master. Yes, absolutely right. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123815/#review80514 ----------------------------------------------------------- On May 17, 2015, 1:23 p.m., Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123815/ > ----------------------------------------------------------- > > (Updated May 17, 2015, 1:23 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > The panel configuration width is defined to a fixed value when it's vertical. > In English, it's not a problem because strings are very compacts. But for example, in French, some strings get too big for the buttons. > > The width is now computed dynamically from the button layout. > I'm really not a QML expert, please let me know if there is a better way to achieve that. > > > Diffs > ----- > > desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml 7cf567e30c99b38e6fbdfa718e4de2ef32c2f5dd > > Diff: https://git.reviewboard.kde.org/r/123815/diff/ > > > Testing > ------- > > Tested in all screen edges. > > > File Attachments > ---------------- > > Truncated text > https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/d04883f4-e479-4e0c-9c49-fb545003ab9d__truncated_button.jpg > After the fix > https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/60e37174-5523-4682-aabb-fc0e23ac5bdc__fixed_button.jpg > > > Thanks, > > Yoann Laissus > > --===============8144303255942246231== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123815/

On May 17th, 2015, 11:33 a.m. UTC, David Edmundson wrote:
Nice work, thanks.
On May 27th, 2015, 8:12 p.m. UTC, Yoann Laissus wrote:
A little late for the 5.3.1 but do I need to backport the patch to the 5.3 branch ?
On May 27th, 2015, 10:33 p.m. UTC, David Edmundson wrote:
If you want it in 5.3.2, yes.
In general it's a combo of 3 factors:
 - how much effort is it to backport
 - is it likely to break something
 - how big of a probelm is the bug
In this case I think it makes sense.
Do you know how to do it?
On May 30th, 2015, 10:24 a.m. UTC, Yoann Laissus wrote:
Hum, as I already commited in master, I would say a cherry-pick ?
Otherwise, I would have commited in 5.3 and then merge in master.

Yes, absolutely right.

- David

On May 17th, 2015, 1:23 p.m. UTC, Yoann Laissus wrote:

Review request for Plasma.

By Yoann Laissus.

Updated May 17, 2015, 1:23 p.m.

Repository: plasma-desktop

Description

The panel configuration width is defined to a fixed value when it's vertical.
In English, it's not a problem because strings are very compacts. But for example, in French, some strings get too big for the buttons.
The width is now computed dynamically from the button layout.
I'm really not a QML expert, please let me know if there is a better way to achieve that.

Testing

Tested in all screen edges.

Diffs

desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml (7cf567e30c99b38e6fbdfa718e4de2ef32c2f5dd)

File Attachments

--===============8144303255942246231==-- --===============7755468900377667263== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7755468900377667263==--