'Re: Review Request 123173: Timer Plasmoid: Add notification on timer completion'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123173: Timer Plasmoid: Add notification on timer completion
From:       "Bernhard Friedreich" <friesoft () gmail ! com>
Date:       2015-03-29 19:53:28
Message-ID: 20150329195328.1187.72903 () mimi ! kde ! org
[Download RAW message or body]

--===============7321735726281574926==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123173/
-----------------------------------------------------------

(Updated March 29, 2015, 7:53 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 99c42f6c8f67984abcc270425a1ab2469d199386 by Bernhard Friedreich \
to branch master.

Repository: kdeplasma-addons

Description
-------

Commit 1: Fixed codingstyle
Commit 2: Fixed warning "Unable to assign int to QEasingCurve"
Commit 3: Added notification on timer completion (not working yet)

Diffs
-----

  applets/timer/package/contents/ui/TimerDigit.qml \
94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405   \
applets/timer/package/contents/ui/timer.qml 09df67004f07352436a30195fb13c2550f8ebce7 

Diff: https://git.reviewboard.kde.org/r/123173/diff/

Testing
-------

Event is fired when the timer is finished (console.log output works) but the \
notification won't show up.

I get this message on console: Are we the only client? (Both have to be true)  false \
true

How can I send a notification from qml (without c++)? Am I on the right track?

[Edit] Looks like the notification is working if the plasmoid is added somewhere but \
not from within plasmawindowed.. any ideas?

Thanks,

Bernhard Friedreich

--===============7321735726281574926==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123173/">https://git.reviewboard.kde.org/r/123173/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Bernhard Friedreich.</div>

<p style="color: grey;"><i>Updated March 29, 2015, 7:53 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 99c42f6c8f67984abcc270425a1ab2469d199386 by \
Bernhard Friedreich to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Commit 1: Fixed codingstyle Commit 2: Fixed warning \
"Unable to assign int to QEasingCurve" Commit 3: Added notification on timer \
completion (not working yet)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Event is fired when the timer is finished (console.log \
output works) but the notification won't show up.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I get \
this message on console: Are we the only client? (Both have to be true)  false \
true</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">How can I send a notification from qml (without c++)? \
Am I on the right track?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">[Edit] Looks like the notification is \
working if the plasmoid is added somewhere but not from within plasmawindowed.. any \
ideas?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/timer/package/contents/ui/TimerDigit.qml <span style="color: \
grey">(94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405)</span></li>

 <li>applets/timer/package/contents/ui/timer.qml <span style="color: \
grey">(09df67004f07352436a30195fb13c2550f8ebce7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123173/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7321735726281574926==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 