From kde-panel-devel Sun Mar 29 19:53:28 2015 From: "Bernhard Friedreich" Date: Sun, 29 Mar 2015 19:53:28 +0000 To: kde-panel-devel Subject: Re: Review Request 123173: Timer Plasmoid: Add notification on timer completion Message-Id: <20150329195328.1187.72903 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142765882113684 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5339683149990577283==" --===============5339683149990577283== Content-Type: multipart/alternative; boundary="===============7321735726281574926==" --===============7321735726281574926== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123173/ ----------------------------------------------------------- (Updated March 29, 2015, 7:53 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit 99c42f6c8f67984abcc270425a1ab2469d199386 by Bernhard Friedreich to branch master. Repository: kdeplasma-addons Description ------- Commit 1: Fixed codingstyle Commit 2: Fixed warning "Unable to assign int to QEasingCurve" Commit 3: Added notification on timer completion (not working yet) Diffs ----- applets/timer/package/contents/ui/TimerDigit.qml 94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405 applets/timer/package/contents/ui/timer.qml 09df67004f07352436a30195fb13c2550f8ebce7 Diff: https://git.reviewboard.kde.org/r/123173/diff/ Testing ------- Event is fired when the timer is finished (console.log output works) but the notification won't show up. I get this message on console: Are we the only client? (Both have to be true) false true How can I send a notification from qml (without c++)? Am I on the right track? [Edit] Looks like the notification is working if the plasmoid is added somewhere but not from within plasmawindowed.. any ideas? Thanks, Bernhard Friedreich --===============7321735726281574926== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123173/

This change has been marked as submitted.

Review request for Plasma.

By Bernhard Friedreich.

Updated March 29, 2015, 7:53 p.m.

Changes

Submitted with commit 99c42f6c8f67984abcc270425a1ab2469d199386 by Bernhard Friedreich to branch master.

Repository: kdeplasma-addons

Description

Commit 1: Fixed codingstyle Commit 2: Fixed warning "Unable to assign int to QEasingCurve" Commit 3: Added notification on timer completion (not working yet)

Testing

Event is fired when the timer is finished (console.log output works) but the notification won't show up.

I get this message on console: Are we the only client? (Both have to be true) false true

How can I send a notification from qml (without c++)? Am I on the right track?

[Edit] Looks like the notification is working if the plasmoid is added somewhere but not from within plasmawindowed.. any ideas?

Diffs

applets/timer/package/contents/ui/TimerDigit.qml (94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405)
applets/timer/package/contents/ui/timer.qml (09df67004f07352436a30195fb13c2550f8ebce7)

--===============7321735726281574926==-- --===============5339683149990577283== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5339683149990577283==--