'Re: Review Request 123173: Timer Plasmoid: Add notification on timer completion'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123173: Timer Plasmoid: Add notification on timer completion
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-03-29 16:04:08
Message-ID: 20150329160408.1187.18909 () mimi ! kde ! org
[Download RAW message or body]

--===============4093263572693815194==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On March 29, 2015, 3:03 p.m., David Edmundson wrote:
> > If it works in plasmashell, ship it.
> 
> Bernhard Friedreich wrote:
> yeah works in plasmashell :)
> 
> I don't have commit access yet - shall I request it? Is this the recommended way? \
> https://identity.kde.org/index.php?r=developerApplication

sure, put me down as someone who approves your request.
Keep up the good work.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123173/#review78176
-----------------------------------------------------------

On March 29, 2015, 2:20 p.m., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123173/
> -----------------------------------------------------------
> 
> (Updated March 29, 2015, 2:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Commit 1: Fixed codingstyle
> Commit 2: Fixed warning "Unable to assign int to QEasingCurve"
> Commit 3: Added notification on timer completion (not working yet)
> 
> 
> Diffs
> -----
> 
> applets/timer/package/contents/ui/TimerDigit.qml \
> 94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405  \
> applets/timer/package/contents/ui/timer.qml \
> 09df67004f07352436a30195fb13c2550f8ebce7  
> Diff: https://git.reviewboard.kde.org/r/123173/diff/
> 
> 
> Testing
> -------
> 
> Event is fired when the timer is finished (console.log output works) but the \
> notification won't show up. 
> I get this message on console: Are we the only client? (Both have to be true)  \
> false true 
> How can I send a notification from qml (without c++)? Am I on the right track?
> 
> [Edit] Looks like the notification is working if the plasmoid is added somewhere \
> but not from within plasmawindowed.. any ideas? 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
> 

--===============4093263572693815194==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123173/">https://git.reviewboard.kde.org/r/123173/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 29th, 2015, 3:03 p.m. UTC, <b>David \
Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If it works in plasmashell, ship it.</p></pre>  \
</blockquote>

 <p>On March 29th, 2015, 3:17 p.m. UTC, <b>Bernhard Friedreich</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yeah \
works in plasmashell :)</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I don't have commit access yet - shall \
I request it? Is this the recommended way? \
https://identity.kde.org/index.php?r=developerApplication</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">sure, \
put me down as someone who approves your request. Keep up the good work.</p></pre>
<br />

<p>- David</p>

<br />
<p>On March 29th, 2015, 2:20 p.m. UTC, Bernhard Friedreich wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Bernhard Friedreich.</div>

<p style="color: grey;"><i>Updated March 29, 2015, 2:20 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Commit 1: Fixed codingstyle Commit 2: Fixed warning \
"Unable to assign int to QEasingCurve" Commit 3: Added notification on timer \
completion (not working yet)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Event is fired when the timer is finished (console.log \
output works) but the notification won't show up.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I get \
this message on console: Are we the only client? (Both have to be true)  false \
true</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">How can I send a notification from qml (without c++)? \
Am I on the right track?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">[Edit] Looks like the notification is \
working if the plasmoid is added somewhere but not from within plasmawindowed.. any \
ideas?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/timer/package/contents/ui/TimerDigit.qml <span style="color: \
grey">(94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405)</span></li>

 <li>applets/timer/package/contents/ui/timer.qml <span style="color: \
grey">(09df67004f07352436a30195fb13c2550f8ebce7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123173/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4093263572693815194==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 