[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121761: Fix build on FreeBSD
From: "Pino Toscano" <pino () kde ! org>
Date: 2014-12-31 14:19:00
Message-ID: 20141231141900.18351.51844 () probe ! kde ! org
[Download RAW message or body]
--===============7567504760866558873==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121761/#review72846
-----------------------------------------------------------
ksmserver/screenlocker/greeter/autotests/killtest.cpp
<https://git.reviewboard.kde.org/r/121761/#comment50723>
This (and all the other cases of this) should rather be:
```
#ifdef SIGUNUSED
...
#endif
```
so the code using this signal is built when it is available, not just "on \
Linux/$OS".
- Pino Toscano
On Dic. 30, 2014, 6:33 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121761/
> -----------------------------------------------------------
>
> (Updated Dic. 30, 2014, 6:33 p.m.)
>
>
> Review request for Plasma and Raphael Kubo da Costa.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Add missing errno.h include
>
> Wrap Linux-only signals in #ifdef Q_OS_LINUX
>
> Fix build with X11 not installed to /usr
>
>
> Diffs
> -----
>
> drkonqi/detachedprocessmonitor.cpp 85a87874c6e9ce47856a01195b42aef9f3a4991a
> drkonqi/systeminformation.cpp 8f5fc7fe789a4bbe23f178e7e940ba1d1a1b59db
> ksmserver/CMakeLists.txt 84a8aa393dfb6ed4671094d1fccbb3c79c53f9af
> ksmserver/screenlocker/greeter/authenticator.cpp \
> ad60f0bd0076cd9c8c3875f13dc92b5da253bb1a \
> ksmserver/screenlocker/greeter/autotests/killtest.cpp \
> 6f2ef114459b5d641e357f3a817b82e7af2e72a3 libkworkspace/CMakeLists.txt \
> 53ce6108bd91f87108206fca02ac303dadf069e1
> Diff: https://git.reviewboard.kde.org/r/121761/diff/
>
>
> Testing
> -------
>
> compiles, still compiles on linux
>
>
> Thanks,
>
> Alex Richardson
>
>
--===============7567504760866558873==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121761/">https://git.reviewboard.kde.org/r/121761/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121761/diff/1/?file=337442#file337442line79" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/screenlocker/greeter/autotests/killtest.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KillTest::testKill_data()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">78</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#ifdef Q_OS_LINUX</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">79</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTest</span><span class="o">::</span><span class="n">newRow</span><span \
class="p">(</span><span class="s">"SIGUNUSED"</span><span \
class="p">)</span> <span class="o"><<</span> <span class="n">SIGUNUSED</span> \
<span class="o"><<</span> <span class="nb">true</span> <span \
class="o"><<</span> <span class="n">QProcess</span><span \
class="o">::</span><span class="n">CrashExit</span><span \
class="p">;</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">79</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QTest</span><span \
class="o">::</span><span class="n">newRow</span><span class="p">(</span><span \
class="s">"SIGUNUSED"</span><span class="p">)</span> <span \
class="o"><<</span> <span class="n">SIGUNUSED</span> <span \
class="o"><<</span> <span class="nb">true</span> <span \
class="o"><<</span> <span class="n">QProcess</span><span \
class="o">::</span><span class="n">CrashExit</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">80</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTest</span><span class="o">::</span><span class="n">newRow</span><span \
class="p">(</span><span class="s">"SIGSTKFLT"</span><span \
class="p">)</span> <span class="o"><<</span> <span class="n">SIGSTKFLT</span> \
<span class="o"><<</span> <span class="nb">true</span> <span \
class="o"><<</span> <span class="n">QProcess</span><span \
class="o">::</span><span class="n">CrashExit</span><span \
class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">81</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#endif</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
(and all the other cases of this) should rather be:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span \
style="color: #BC7A00">#ifdef SIGUNUSED</span>
...
<span style="color: #BC7A00">#endif</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">so the code using this signal is built when it is \
available, not just "on Linux/$OS".</p></pre> </div>
</div>
<br />
<p>- Pino Toscano</p>
<br />
<p>On dicembre 30th, 2014, 6:33 p.m. UTC, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Raphael Kubo da Costa.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Dic. 30, 2014, 6:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add missing errno.h include</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wrap \
Linux-only signals in #ifdef Q_OS_LINUX</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix build with X11 not \
installed to /usr</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiles, still compiles on linux</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/detachedprocessmonitor.cpp <span style="color: \
grey">(85a87874c6e9ce47856a01195b42aef9f3a4991a)</span></li>
<li>drkonqi/systeminformation.cpp <span style="color: \
grey">(8f5fc7fe789a4bbe23f178e7e940ba1d1a1b59db)</span></li>
<li>ksmserver/CMakeLists.txt <span style="color: \
grey">(84a8aa393dfb6ed4671094d1fccbb3c79c53f9af)</span></li>
<li>ksmserver/screenlocker/greeter/authenticator.cpp <span style="color: \
grey">(ad60f0bd0076cd9c8c3875f13dc92b5da253bb1a)</span></li>
<li>ksmserver/screenlocker/greeter/autotests/killtest.cpp <span style="color: \
grey">(6f2ef114459b5d641e357f3a817b82e7af2e72a3)</span></li>
<li>libkworkspace/CMakeLists.txt <span style="color: \
grey">(53ce6108bd91f87108206fca02ac303dadf069e1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121761/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7567504760866558873==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic