From kde-panel-devel Wed Dec 31 14:19:00 2014 From: "Pino Toscano" Date: Wed, 31 Dec 2014 14:19:00 +0000 To: kde-panel-devel Subject: Re: Review Request 121761: Fix build on FreeBSD Message-Id: <20141231141900.18351.51844 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142003556102230 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4134102808037935183==" --===============4134102808037935183== Content-Type: multipart/alternative; boundary="===============7567504760866558873==" --===============7567504760866558873== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121761/#review72846 ----------------------------------------------------------- ksmserver/screenlocker/greeter/autotests/killtest.cpp This (and all the other cases of this) should rather be: ``` #ifdef SIGUNUSED ... #endif ``` so the code using this signal is built when it is available, not just "on Linux/$OS". - Pino Toscano On Dic. 30, 2014, 6:33 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121761/ > ----------------------------------------------------------- > > (Updated Dic. 30, 2014, 6:33 p.m.) > > > Review request for Plasma and Raphael Kubo da Costa. > > > Repository: plasma-workspace > > > Description > ------- > > Add missing errno.h include > > Wrap Linux-only signals in #ifdef Q_OS_LINUX > > Fix build with X11 not installed to /usr > > > Diffs > ----- > > drkonqi/detachedprocessmonitor.cpp 85a87874c6e9ce47856a01195b42aef9f3a4991a > drkonqi/systeminformation.cpp 8f5fc7fe789a4bbe23f178e7e940ba1d1a1b59db > ksmserver/CMakeLists.txt 84a8aa393dfb6ed4671094d1fccbb3c79c53f9af > ksmserver/screenlocker/greeter/authenticator.cpp ad60f0bd0076cd9c8c3875f13dc92b5da253bb1a > ksmserver/screenlocker/greeter/autotests/killtest.cpp 6f2ef114459b5d641e357f3a817b82e7af2e72a3 > libkworkspace/CMakeLists.txt 53ce6108bd91f87108206fca02ac303dadf069e1 > > Diff: https://git.reviewboard.kde.org/r/121761/diff/ > > > Testing > ------- > > compiles, still compiles on linux > > > Thanks, > > Alex Richardson > > --===============7567504760866558873== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121761/

ksmserver/screenlocker/greeter/autotests/killtest.cpp (Diff revision 1)
void KillTest::testKill_data()
		78	#ifdef Q_OS_LINUX
79	QTest::newRow("SIGUNUSED") << SIGUNUSED << true << QProcess::CrashExit;	79	QTest::newRow("SIGUNUSED") << SIGUNUSED << true << QProcess::CrashExit;
		80	QTest::newRow("SIGSTKFLT") << SIGSTKFLT << true << QProcess::CrashExit;
		81	#endif

This (and all the other cases of this) should rather be:

#ifdef SIGUNUSED
 ...
#endif

so the code using this signal is built when it is available, not just "on Linux/$OS".

- Pino Toscano

On dicembre 30th, 2014, 6:33 p.m. UTC, Alex Richardson wrote:

Review request for Plasma and Raphael Kubo da Costa.

By Alex Richardson.

Updated Dic. 30, 2014, 6:33 p.m.

Repository: plasma-workspace

Description

Add missing errno.h include

Wrap Linux-only signals in #ifdef Q_OS_LINUX

Fix build with X11 not installed to /usr

Testing

compiles, still compiles on linux

Diffs

drkonqi/detachedprocessmonitor.cpp (85a87874c6e9ce47856a01195b42aef9f3a4991a)
drkonqi/systeminformation.cpp (8f5fc7fe789a4bbe23f178e7e940ba1d1a1b59db)
ksmserver/CMakeLists.txt (84a8aa393dfb6ed4671094d1fccbb3c79c53f9af)
ksmserver/screenlocker/greeter/authenticator.cpp (ad60f0bd0076cd9c8c3875f13dc92b5da253bb1a)
ksmserver/screenlocker/greeter/autotests/killtest.cpp (6f2ef114459b5d641e357f3a817b82e7af2e72a3)
libkworkspace/CMakeLists.txt (53ce6108bd91f87108206fca02ac303dadf069e1)

--===============7567504760866558873==-- --===============4134102808037935183== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4134102808037935183==--