'Re: Review Request 120386: Fix Apply button in applet configuration'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120386: Fix Apply button in applet configuration
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2014-09-29 12:24:09
Message-ID: 20140929122409.15676.30771 () probe ! kde ! org
[Download RAW message or body]

--===============6030570862698038476==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120386/
-----------------------------------------------------------

(Updated Sept. 29, 2014, 12:24 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Bugs: 339428
    https://bugs.kde.org/show_bug.cgi?id=339428

Repository: plasma-desktop

Description
-------

There's no need to call restoreConfiguration() in Component.onCompleted since the \
explicit manipulation of the StackView's sourceFile property in said method will \
already trigger the onSourceFileChanged handler which will restoreConfigration() \
also.

This lead to the issue that for data structures QML cannot compare, like the Array of \
extra items in systray config, triggered the change handler on re-assignment by the \
method running a second time enabling the Apply button.

Diffs
-----

  desktoppackage/contents/configuration/AppletConfiguration.qml 2da918e 

Diff: https://git.reviewboard.kde.org/r/120386/diff/

Testing
-------

Opened config, changed and applied values, switched between pages, in systray and \
digitalclock config. Config restored properly.

Thanks,

Kai Uwe Broulik

--===============6030570862698038476==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120386/">https://git.reviewboard.kde.org/r/120386/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Sept. 29, 2014, 12:24 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=339428">339428</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There's no need to call restoreConfiguration() in \
Component.onCompleted since the explicit manipulation of the StackView's sourceFile \
property in said method will already trigger the onSourceFileChanged handler which \
will restoreConfigration() also.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This lead to the issue \
that for data structures QML cannot compare, like the Array of extra items in systray \
config, triggered the change handler on re-assignment by the method running a second \
time enabling the Apply button.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Opened config, changed and applied values, switched \
between pages, in systray and digitalclock config. Config restored \
properly.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/configuration/AppletConfiguration.qml <span \
style="color: grey">(2da918e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120386/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6030570862698038476==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 