From kde-panel-devel Mon Sep 29 12:24:09 2014 From: "Kai Uwe Broulik" Date: Mon, 29 Sep 2014 12:24:09 +0000 To: kde-panel-devel Subject: Re: Review Request 120386: Fix Apply button in applet configuration Message-Id: <20140929122409.15676.30771 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141199346518284 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7636086341664268498==" --===============7636086341664268498== Content-Type: multipart/alternative; boundary="===============6030570862698038476==" --===============6030570862698038476== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120386/ ----------------------------------------------------------- (Updated Sept. 29, 2014, 12:24 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Bugs: 339428 https://bugs.kde.org/show_bug.cgi?id=339428 Repository: plasma-desktop Description ------- There's no need to call restoreConfiguration() in Component.onCompleted since the explicit manipulation of the StackView's sourceFile property in said method will already trigger the onSourceFileChanged handler which will restoreConfigration() also. This lead to the issue that for data structures QML cannot compare, like the Array of extra items in systray config, triggered the change handler on re-assignment by the method running a second time enabling the Apply button. Diffs ----- desktoppackage/contents/configuration/AppletConfiguration.qml 2da918e Diff: https://git.reviewboard.kde.org/r/120386/diff/ Testing ------- Opened config, changed and applied values, switched between pages, in systray and digitalclock config. Config restored properly. Thanks, Kai Uwe Broulik --===============6030570862698038476== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120386/

This change has been marked as submitted.

Review request for Plasma.
By Kai Uwe Broulik.

Updated Sept. 29, 2014, 12:24 p.m.

Bugs: 339428
Repository: plasma-desktop

Description 

There's no need to call restoreConfiguration() in Component.onCompleted since the explicit manipulation of the StackView's sourceFile property in said method will already trigger the onSourceFileChanged handler which will restoreConfigration() also.


This lead to the issue that for data structures QML cannot compare, like the Array of extra items in systray config, triggered the change handler on re-assignment by the method running a second time enabling the Apply button.

Testing 

Opened config, changed and applied values, switched between pages, in systray and digitalclock config. Config restored properly.

Diffs

  • desktoppackage/contents/configuration/AppletConfiguration.qml (2da918e)

View Diff
--===============6030570862698038476==-- --===============7636086341664268498== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7636086341664268498==--