[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120419: [ksmserver] Get rid of KDELibs4Support...
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-09-29 12:34:21
Message-ID: 20140929123421.15676.21485 () probe ! kde ! org
[Download RAW message or body]
--===============1676655851662089128==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120419/#review67619
-----------------------------------------------------------
ksmserver/legacy.cpp
<https://git.reviewboard.kde.org/r/120419/#comment47124>
Maybe qCDebug?
Other than that it's fine. Good work!
We should find a solution for the Solid/PowerManagement part...
- Aleix Pol Gonzalez
On Sept. 29, 2014, 10:50 a.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120419/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 10:50 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> ...as much as possible. still left some Solid usage.
>
>
> Diffs
> -----
>
> ksmserver/CMakeLists.txt 49870fb
> ksmserver/client.cpp 6232d71
> ksmserver/legacy.cpp bb102a8
> ksmserver/main.cpp 75ca468
> ksmserver/server.cpp a2cd6e6
> ksmserver/shutdown.cpp b67a6a9
> ksmserver/shutdowndlg.cpp 5c484f3
> ksmserver/startup.cpp a173237
>
> Diff: https://git.reviewboard.kde.org/r/120419/diff/
>
>
> Testing
> -------
>
> starting/shutdown, restoring session/clean session all seem to work
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
--===============1676655851662089128==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120419/">https://git.reviewboard.kde.org/r/120419/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120419/diff/1/?file=315668#file315668line81" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/legacy.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
int winsErrorHandler(Display *, XErrorEvent *ev)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">80</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">k</span>Debug</span><span class="p">(</span><span class="hl"> </span><span \
class="mi"><span class="hl">1218</span></span><span class="hl"> </span><span \
class="p">)</span> <span class="o"><<</span> <span class="s">"Saving \
legacy session apps"</span><span class="p">;</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">80</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span \
class="o"><<</span> <span class="s">"Saving legacy session \
apps"</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe \
qCDebug?</p></pre> </div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Other \
than that it's fine. Good work!</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">We should find a \
solution for the Solid/PowerManagement part...</p></pre>
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On September 29th, 2014, 10:50 a.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2014, 10:50 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">...as much as possible. still left some Solid \
usage.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">starting/shutdown, restoring session/clean session all \
seem to work</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/CMakeLists.txt <span style="color: grey">(49870fb)</span></li>
<li>ksmserver/client.cpp <span style="color: grey">(6232d71)</span></li>
<li>ksmserver/legacy.cpp <span style="color: grey">(bb102a8)</span></li>
<li>ksmserver/main.cpp <span style="color: grey">(75ca468)</span></li>
<li>ksmserver/server.cpp <span style="color: grey">(a2cd6e6)</span></li>
<li>ksmserver/shutdown.cpp <span style="color: grey">(b67a6a9)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(5c484f3)</span></li>
<li>ksmserver/startup.cpp <span style="color: grey">(a173237)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120419/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1676655851662089128==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic