'Re: Review Request 118908: Adjust taskmanager tooltip size to window thumbnail'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118908: Adjust taskmanager tooltip size to window thumbnail
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2014-08-24 13:46:09
Message-ID: 20140824134609.11205.86608 () probe ! kde ! org
[Download RAW message or body]

--===============1574845026326864676==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118908/
-----------------------------------------------------------

(Updated Aug. 24, 2014, 1:46 nachm.)

Status
------

This change has been discarded.

Review request for Plasma and Eike Hein.

Repository: plasma-desktop

Description
-------

Now that we can know the exact geometry of the window thumbnail the tooltip is \
adjusted to respect that.

Diffs
-----

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml ca5f95b 

Diff: https://git.reviewboard.kde.org/r/118908/diff/

Testing
-------

Tested with single window, grouped window as well as minimized window (icon). Looks \
fine although there still is excess padding left and right of the thumbnail I don't \
know where that comes. Needs a bit of spacing adjustments as well.

File Attachments
----------------

Narrow window
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/7773a10d-7ee9-4a06-b5b4-bd03b7ce8566__taskmanagertooltip.png
 Wide window
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/8e29f459-af59-43c1-b171-8b7aacd237af__taskmanagertooltip1.png
 Grouped
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/f1df0096-271c-4229-8466-8374ef56492a__taskmanagertooltip2.png

Thanks,

Kai Uwe Broulik

--===============1574845026326864676==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118908/">https://git.reviewboard.kde.org/r/118908/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Eike Hein.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Aug. 24, 2014, 1:46 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now that we can know the exact geometry of the window thumbnail the \
tooltip is adjusted to respect that.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with single window, grouped window as well as minimized window \
(icon). Looks fine although there still is excess padding left and right of the \
thumbnail I don&#39;t know where that comes. Needs a bit of spacing adjustments as \
well.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/taskmanager/package/contents/ui/ToolTipDelegate.qml <span style="color: \
grey">(ca5f95b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118908/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/7773a10d-7ee9-4a06-b5b4-bd03b7ce8566__taskmanagertooltip.png">Narrow \
window</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/8e29f459-af59-43c1-b171-8b7aacd237af__taskmanagertooltip1.png">Wide \
window</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/f1df0096-271c-4229-8466-8374ef56492a__taskmanagertooltip2.png">Grouped</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1574845026326864676==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 