[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118908: Adjust taskmanager tooltip size to window thumbnail
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-06-23 19:34:59
Message-ID: 20140623193459.31954.67506 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 23, 2014, 7:16 p.m., Eike Hein wrote:
> > This causes the tooltips to no longer be uniform in size, which causes extra \
> > visual busyness when moving between tasks. Tooltip resize performance also isn't \
> > stellar right now, and size changes are especially deadly for right-aligned \
> > tooltips (i.e. vertical panel on the right screen edge), causing odd dancing. So \
> > conceptually it's a -1 for me. Additionally on the first screenshot the \
> > left/right margins also aren't uniform for icon and text label.
>
> Kai Uwe Broulik wrote:
> True, didn't test with vertical panel :/ What a pity.
probably the extra padding the current version has makes it look a bit cleaner.
also true that windows with "wrong" proportions are never going to look good, so hard \
to say in an objective way what's the best approach.
minimizing resizes (even if resizing was relly fast) seems a good principle tough
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118908/#review60837
-----------------------------------------------------------
On June 23, 2014, 6:39 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118908/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 6:39 p.m.)
>
>
> Review request for Plasma and Eike Hein.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Now that we can know the exact geometry of the window thumbnail the tooltip is \
> adjusted to respect that.
>
> Diffs
> -----
>
> applets/taskmanager/package/contents/ui/ToolTipDelegate.qml ca5f95b
>
> Diff: https://git.reviewboard.kde.org/r/118908/diff/
>
>
> Testing
> -------
>
> Tested with single window, grouped window as well as minimized window (icon). Looks \
> fine although there still is excess padding left and right of the thumbnail I don't \
> know where that comes. Needs a bit of spacing adjustments as well.
>
> File Attachments
> ----------------
>
> Narrow window
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/7773a10d-7ee9-4a06-b5b4-bd03b7ce8566__taskmanagertooltip.png
> Wide window
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/8e29f459-af59-43c1-b171-8b7aacd237af__taskmanagertooltip1.png
> Grouped
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/f1df0096-271c-4229-8466-8374ef56492a__taskmanagertooltip2.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118908/">https://git.reviewboard.kde.org/r/118908/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 23rd, 2014, 7:16 p.m. UTC, <b>Eike \
Hein</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This causes the tooltips to no longer be uniform in size, which causes \
extra visual busyness when moving between tasks. Tooltip resize performance also \
isn't stellar right now, and size changes are especially deadly for right-aligned \
tooltips (i.e. vertical panel on the right screen edge), causing odd dancing. So \
conceptually it's a -1 for me. Additionally on the first screenshot the \
left/right margins also aren't uniform for icon and text label.</pre> \
</blockquote>
<p>On June 23rd, 2014, 7:33 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">True, didn't test \
with vertical panel :/ What a pity.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">probably the extra \
padding the current version has makes it look a bit cleaner. also true that windows \
with "wrong" proportions are never going to look good, so hard to say in an \
objective way what's the best approach.
minimizing resizes (even if resizing was relly fast) seems a good principle \
tough</pre> <br />
<p>- Marco</p>
<br />
<p>On June 23rd, 2014, 6:39 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Eike Hein.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated June 23, 2014, 6:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now that we can know the exact geometry of the window thumbnail the \
tooltip is adjusted to respect that.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with single window, grouped window as well as minimized window \
(icon). Looks fine although there still is excess padding left and right of the \
thumbnail I don't know where that comes. Needs a bit of spacing adjustments as \
well.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/taskmanager/package/contents/ui/ToolTipDelegate.qml <span style="color: \
grey">(ca5f95b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118908/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/7773a10d-7ee9-4a06-b5b4-bd03b7ce8566__taskmanagertooltip.png">Narrow \
window</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/8e29f459-af59-43c1-b171-8b7aacd237af__taskmanagertooltip1.png">Wide \
window</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/f1df0096-271c-4229-8466-8374ef56492a__taskmanagertooltip2.png">Grouped</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic