'Re: Review Request 119739: Don't hardcode applet configuration sidebar size'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119739: Don't hardcode applet configuration sidebar size
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2014-08-24 13:45:00
Message-ID: 20140824134500.11205.2315 () probe ! kde ! org
[Download RAW message or body]

--===============1158255182815876951==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119739/
-----------------------------------------------------------

(Updated Aug. 24, 2014, 1:45 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-desktop

Description
-------

The sidebar in the applet configuration which tries to mimic the sidebar in \
traditional KCMs is hardcoded to 100px resulting in cramped text on my machine.

The grid * 7 is completely arbitrary and I don't like it but I have no idea what \
heuristics Qt uses to determin the size of that panel.

Diffs
-----

  desktoppackage/contents/configuration/AppletConfiguration.qml 546b8db 

Diff: https://git.reviewboard.kde.org/r/119739/diff/

Testing
-------

It looks fine on my machine (fonts at 180dpi) but somebody with an ordinary display \
should definitely verify that.

Thanks,

Kai Uwe Broulik

--===============1158255182815876951==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119739/">https://git.reviewboard.kde.org/r/119739/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Aug. 24, 2014, 1:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The sidebar in the applet configuration which tries to \
mimic the sidebar in traditional KCMs is hardcoded to 100px resulting in cramped text \
on my machine.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The grid * 7 is completely arbitrary \
and I don't like it but I have no idea what heuristics Qt uses to determin the size \
of that panel.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It looks fine on my machine (fonts at 180dpi) but \
somebody with an ordinary display should definitely verify that.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/configuration/AppletConfiguration.qml <span \
style="color: grey">(546b8db)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119739/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1158255182815876951==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 