[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111770: Implemented search feature in Local Browsing.
From: Akshay Ratan <akshayratan () gmail ! com>
Date: 2014-07-30 16:57:27
Message-ID: CAKTp-8RbSQuGGXqT37OJtKdzsH8uVOOu6OYgzNnDn+s6jdDNwQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hello Sinny,
I remember there was some issue with Qt Library code itself. Shantanu
earlier told me to wait till that is fixed by Qt developers.
Anyways, I l close the request soon.
On Wed, Jul 30, 2014 at 5:15 PM, Sinny Kumari <ksinny@gmail.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/111770/
>
> On September 11th, 2013, 7:31 a.m. UTC, *Sinny Kumari* wrote:
>
> One issue
> Suppose I searched for videos folder in search bar. Now, with search filter i can \
> see videos folder in mediabrowser. Later when I click on video folder to broswe \
> inside then it shows me blank. This is happening becasue still it is trying to \
> search with name video. This should not happen, search should be called only for \
> current browsing page where user typed it
> On September 11th, 2013, 7:37 a.m. UTC, *Sinny Kumari* wrote:
>
> Snapshots:http://wstaw.org/m/2013/09/11/snapshot1.png (when searched for \
> videos)http://wstaw.org/m/2013/09/11/snapshot2.png (when clicked on filterd search \
> i.e on videos)
> Status?
>
>
> - Sinny
>
> On September 10th, 2013, 7:31 p.m. UTC, Akshay Ratan wrote:
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith
> Haridasan.
> By Akshay Ratan.
>
> *Updated Sept. 10, 2013, 7:31 p.m.*
> *Repository: * plasma-mediacenter
> Description
>
> Plasma Media Center now supports searching in local files and media. Used Regular \
> expression to match the name.
> Request to merge the branch akshay_localSearch to master of PMC.
>
> Testing
>
> Works as intended.
>
> Diffs
>
> - browsingbackends/localfiles/localfilesabstractbackend.h (84758e4)
> - browsingbackends/localfiles/localfilesabstractbackend.cpp (1144e49)
> - browsingbackends/localfiles/localfilesabstractmodel.h (43f50b7)
> - browsingbackends/localfiles/localfilesabstractmodel.cpp (ebfc602)
> - mediaelements/mediabrowser/MediaBrowser.qml (6ae777f)
>
> View Diff <https://git.reviewboard.kde.org/r/111770/diff/>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
--
Akshay
[Attachment #5 (text/html)]
<div dir="ltr">Hello Sinny,<div><br></div><div>I remember there was some issue with \
Qt Library code itself. Shantanu earlier told me to wait till that is fixed by Qt \
developers. </div><div><br></div><div>Anyways, I l close the request soon.</div> \
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jul 30, 2014 \
at 5:15 PM, Sinny Kumari <span dir="ltr"><<a href="mailto:ksinny@gmail.com" \
target="_blank">ksinny@gmail.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border:1px #c9c399 \
solid;border-radius:6px"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/111770/" \
target="_blank">https://git.reviewboard.kde.org/r/111770/</a> </td>
</tr>
</tbody></table>
<br>
<blockquote style="margin-left:1em;border-left:2px solid \
#d0d0d0;padding-left:10px"><div class=""> <p style="margin-top:0">On September 11th, \
2013, 7:31 a.m. UTC, <b>Sinny Kumari</b> wrote:</p> </div><div class=""><blockquote \
style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px"> <pre \
style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">One \
issue Suppose I searched for videos folder in search bar. Now, with search filter i \
can see videos folder in mediabrowser. Later when I click on video folder to broswe \
inside then it shows me blank. This is happening becasue still it is trying to search \
with name video. This should not happen, search should be called only for current \
browsing page where user typed it</pre>
</blockquote>
</div><div class=""><p>On September 11th, 2013, 7:37 a.m. UTC, <b>Sinny Kumari</b> \
wrote:</p> <blockquote style="margin-left:1em;border-left:2px solid \
#d0d0d0;padding-left:10px"> <pre \
style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Snapshots:
<a href="http://wstaw.org/m/2013/09/11/snapshot1.png" \
target="_blank">http://wstaw.org/m/2013/09/11/snapshot1.png</a> (when searched for \
videos) <a href="http://wstaw.org/m/2013/09/11/snapshot2.png" \
target="_blank">http://wstaw.org/m/2013/09/11/snapshot2.png</a> (when clicked on \
filterd search i.e on videos) </pre>
</blockquote>
</div></blockquote>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p \
style="padding:0;margin:0;line-height:inherit;white-space:inherit">Status?</p></pre><div \
class="">
<br>
<p>- Sinny</p>
<br>
<p>On September 10th, 2013, 7:31 p.m. UTC, Akshay Ratan wrote:</p>
</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border:1px #888a85 solid;border-radius:6px"> <tbody><tr>
<td><div class="">
<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Akshay Ratan.</div>
<p style="color:grey"><i>Updated Sept. 10, 2013, 7:31 p.m.</i></p>
</div><div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
plasma-mediacenter
</div><div class="">
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Plasma \
Media Center now supports searching in local files and media. Used Regular expression \
to match the name.
Request to merge the branch akshay_localSearch to master of PMC.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Works \
as intended.</pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>browsingbackends/localfiles/localfilesabstractbackend.h <span \
style="color:grey">(84758e4)</span></li>
<li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span \
style="color:grey">(1144e49)</span></li>
<li>browsingbackends/localfiles/localfilesabstractmodel.h <span \
style="color:grey">(43f50b7)</span></li>
<li>browsingbackends/localfiles/localfilesabstractmodel.cpp <span \
style="color:grey">(ebfc602)</span></li>
<li>mediaelements/mediabrowser/MediaBrowser.qml <span \
style="color:grey">(6ae777f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/111770/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
</div></td>
</tr>
</tbody></table>
</div>
</div>
<br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Akshay </div>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic