[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.
From: "R.Harish Navnit" <harishnavnit () gmail ! com>
Date: 2014-07-30 17:06:56
Message-ID: 20140730170656.15443.62779 () probe ! kde ! org
[Download RAW message or body]
--===============6402672845075161686==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118406/
-----------------------------------------------------------
(Updated July 30, 2014, 5:06 p.m.)
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Changes
-------
[Incomplete] With this diff, if an error is found with any media file in a playlist, \
it is skipped silently. However, I'm facing troubles with showing the \
disabled/enabled(can be done through the opacity property in delegate) status of \
media files. I would like some help with that. Thanks !
Bugs: 333764
http://bugs.kde.org/show_bug.cgi?id=333764
Repository: plasma-mediacenter
Description
-------
If a media(in a playlist) is located in an inaccessible location, then the user is \
notified about the same.
Diffs
-----
mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c
Diff: https://git.reviewboard.kde.org/r/118406/diff/
Testing (updated)
-------
1. Load media to a playlist.
2. Unmount the device containing media.
3. Check if the user is notified of the location being inaccessible
--yes, the user is notified
4. Mount the device containing media and play a media from playlist.
-- The media plays properly.
File Attachments
----------------
wihtout_i18n.png
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png
Thanks,
R.Harish Navnit
--===============6402672845075161686==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118406/">https://git.reviewboard.kde.org/r/118406/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By R.Harish Navnit.</div>
<p style="color: grey;"><i>Updated July 30, 2014, 5:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[Incomplete] With this diff, if an error is found with any media file in \
a playlist, it is skipped silently. However, I'm facing troubles with showing the \
disabled/enabled(can be done through the opacity property in delegate) status of \
media files. I would like some help with that. Thanks ! </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333764">333764</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If a media(in a playlist) is located in an \
inaccessible location, then the user is notified about the same. </p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">1. Load media to a playlist.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> 2. \
Unmount the device containing media.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> 3. Check if the user \
is notified of the location being inaccessible<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
--yes, the user is notified<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> 4. Mount the device containing media \
and play a media from playlist.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
-- The media plays properly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediaplayer/MediaPlayer.qml <span style="color: \
grey">(98f1d2c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118406/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png">wihtout_i18n.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6402672845075161686==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic