[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111553: Fix for the Revision 2f4ab1e6 and Subtitle feature extension in PMC to .s
From: "Sinny Kumari" <ksinny () gmail ! com>
Date: 2014-07-30 11:49:37
Message-ID: 20140730114937.15443.40128 () probe ! kde ! org
[Download RAW message or body]
--===============3411490152095092033==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 18, 2013, 5:57 p.m., Sujith Haridasan wrote:
> > I tested a video with srt, txt and sub file extensions. And I found srt worked \
> > fine. But when I played a video with .sub as subtitle file then it was failing \
> > show the subtitle. So may be you may have to look into the sub files. Since I \
> > don't have txt files. I couldn't test them.
Akshay, please discard this review request.
- Sinny
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111553/#review36137
-----------------------------------------------------------
On July 17, 2013, 5:25 p.m., Akshay Ratan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/111553/
> -----------------------------------------------------------
>
> (Updated July 17, 2013, 5:25 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> This patch essentially aims at extending the subtitle feature to .sub file format \
> also.
> Also, this serves as a fix after the Revision 2f4ab1e6 \
> (https://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/repositor \
> y/revisions/2f4ab1e61149bd9b9487d985845ebdc1b8ec41bb/diff/libs/mediacenter/subtitleprovider.cpp) \
> breaks the existing .srt subtitle support as well.
> Steps to test:
> 1) Play a movie or any video file which has a .sub or .txt or .srt format subtitle.
> 2) Subtitles should come as the video play ( Ofcourse only is the subtitle file \
> name is same as that of movie file name)
>
> Diffs
> -----
>
> libs/mediacenter/subtitleprovider.h 8647ded
> libs/mediacenter/subtitleprovider.cpp 32094b0
> mediaelements/mediaplayer/MediaPlayer.qml 2567312
>
> Diff: https://git.reviewboard.kde.org/r/111553/diff/
>
>
> Testing
> -------
>
> Shantanu : I guess the subtitle patch which got committed in the master in that \
> revision was by mistake. That broke the existing subtitle support for .srt as well. \
> Applying this one over it solves the issue :)
> However, please test it once as still on my system , when a .sub subtitle should \
> play , following is the debug console error output ::
> (plasma-mediacenter:12999): GStreamer-CRITICAL **: gst_pad_link_full: assertion \
> `GST_IS_PAD (sinkpad)' failed
>
> .srt subtitle plays fine :)
>
>
>
> Thanks,
>
> Akshay Ratan
>
>
--===============3411490152095092033==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/111553/">https://git.reviewboard.kde.org/r/111553/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 18th, 2013, 5:57 p.m. UTC, <b>Sujith \
Haridasan</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested a video with srt, txt and sub file extensions. And I found srt \
worked fine. But when I played a video with .sub as subtitle file then it was failing \
show the subtitle. So may be you may have to look into the sub files. Since I \
don't have txt files. I couldn't test them. </pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Akshay, please discard this review request.</p></pre> <br />
<p>- Sinny</p>
<br />
<p>On July 17th, 2013, 5:25 p.m. UTC, Akshay Ratan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Akshay Ratan.</div>
<p style="color: grey;"><i>Updated July 17, 2013, 5:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch essentially aims at extending the subtitle feature to .sub \
file format also.
Also, this serves as a fix after the Revision 2f4ab1e6 \
(https://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/repository/ \
revisions/2f4ab1e61149bd9b9487d985845ebdc1b8ec41bb/diff/libs/mediacenter/subtitleprovider.cpp) \
breaks the existing .srt subtitle support as well.
Steps to test:
1) Play a movie or any video file which has a .sub or .txt or .srt format subtitle.
2) Subtitles should come as the video play ( Ofcourse only is the subtitle file name \
is same as that of movie file name) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Shantanu : I guess the subtitle patch which got committed in the master \
in that revision was by mistake. That broke the existing subtitle support for .srt as \
well. Applying this one over it solves the issue :)
However, please test it once as still on my system , when a .sub subtitle should play \
, following is the debug console error output ::
(plasma-mediacenter:12999): GStreamer-CRITICAL **: gst_pad_link_full: assertion \
`GST_IS_PAD (sinkpad)' failed
.srt subtitle plays fine :)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/mediacenter/subtitleprovider.h <span style="color: \
grey">(8647ded)</span></li>
<li>libs/mediacenter/subtitleprovider.cpp <span style="color: \
grey">(32094b0)</span></li>
<li>mediaelements/mediaplayer/MediaPlayer.qml <span style="color: \
grey">(2567312)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/111553/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3411490152095092033==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic