--===============4091249204916324200== Content-Type: multipart/alternative; boundary="===============3411490152095092033==" --===============3411490152095092033== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 18, 2013, 5:57 p.m., Sujith Haridasan wrote: > > I tested a video with srt, txt and sub file extensions. And I found srt worked fine. But when I played a video with .sub as subtitle file then it was failing show the subtitle. So may be you may have to look into the sub files. Since I don't have txt files. I couldn't test them. Akshay, please discard this review request. - Sinny ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111553/#review36137 ----------------------------------------------------------- On July 17, 2013, 5:25 p.m., Akshay Ratan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/111553/ > ----------------------------------------------------------- > > (Updated July 17, 2013, 5:25 p.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > This patch essentially aims at extending the subtitle feature to .sub file format also. > > Also, this serves as a fix after the Revision 2f4ab1e6 (https://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/repository/revisions/2f4ab1e61149bd9b9487d985845ebdc1b8ec41bb/diff/libs/mediacenter/subtitleprovider.cpp) breaks the existing .srt subtitle support as well. > > Steps to test: > 1) Play a movie or any video file which has a .sub or .txt or .srt format subtitle. > 2) Subtitles should come as the video play ( Ofcourse only is the subtitle file name is same as that of movie file name) > > > Diffs > ----- > > libs/mediacenter/subtitleprovider.h 8647ded > libs/mediacenter/subtitleprovider.cpp 32094b0 > mediaelements/mediaplayer/MediaPlayer.qml 2567312 > > Diff: https://git.reviewboard.kde.org/r/111553/diff/ > > > Testing > ------- > > Shantanu : I guess the subtitle patch which got committed in the master in that revision was by mistake. That broke the existing subtitle support for .srt as well. Applying this one over it solves the issue :) > > However, please test it once as still on my system , when a .sub subtitle should play , following is the debug console error output :: > > (plasma-mediacenter:12999): GStreamer-CRITICAL **: gst_pad_link_full: assertion `GST_IS_PAD (sinkpad)' failed > > > .srt subtitle plays fine :) > > > > Thanks, > > Akshay Ratan > > --===============3411490152095092033== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111553/

On July 18th, 2013, 5:57 p.m. UTC, Sujith Haridasan wrote:

I tested a video with srt, txt and sub file extensions. And I found srt worked fine. But when I played a video with .sub as subtitle file then it was failing show the subtitle. So may be you may have to look into the sub files. Since I don't have txt files. I couldn't test them.

Akshay, please discard this review request.

- Sinny

On July 17th, 2013, 5:25 p.m. UTC, Akshay Ratan wrote:

Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.

By Akshay Ratan.

Updated July 17, 2013, 5:25 p.m.

Repository: plasma-mediacenter

Description

This patch essentially aims at extending the subtitle feature to .sub file format also.

Also, this serves as a fix after the Revision 2f4ab1e6 (https://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/repository/revisions/2f4ab1e61149bd9b9487d985845ebdc1b8ec41bb/diff/libs/mediacenter/subtitleprovider.cpp) breaks the existing .srt subtitle support as well.

Steps to test:
1) Play a movie or any video file which has a .sub or .txt or .srt format subtitle.
2) Subtitles should come as the video play ( Ofcourse only is the subtitle file name is same as that of movie file name)

Testing

Shantanu : I guess the subtitle patch which got committed in the master in that revision was by mistake. That broke the existing subtitle support for .srt as well. Applying this one over it solves the issue :)

However, please test it once as still on my system , when a .sub subtitle should play , following is the debug console error output :: 

(plasma-mediacenter:12999): GStreamer-CRITICAL **: gst_pad_link_full: assertion `GST_IS_PAD (sinkpad)' failed


.srt subtitle plays fine :)

Diffs

libs/mediacenter/subtitleprovider.h (8647ded)
libs/mediacenter/subtitleprovider.cpp (32094b0)
mediaelements/mediaplayer/MediaPlayer.qml (2567312)

--===============3411490152095092033==-- --===============4091249204916324200== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4091249204916324200==--