'Re: Review Request 102464: Add scrollbar support for the Web Slice plasmoid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 102464: Add scrollbar support for the Web Slice plasmoid
From:       "Javier Llorente" <javier () kde ! org>
Date:       2014-07-29 9:26:49
Message-ID: 20140729092649.15440.18169 () probe ! kde ! org
[Download RAW message or body]

--===============1985187581824579300==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102464/
-----------------------------------------------------------

(Updated July 29, 2014, 9:26 a.m.)

Status
------

This change has been discarded.

Review request for Plasma.

Repository: kdeplasma-addons

Description
-------

I have basically added a function to enable/disable the scrollbar on Web Slice.

Diffs
-----

  applets/webslice/kgraphicswebslice.h dfb60e5b0b3765f8e2324f832f78a1abac0db510 
  applets/webslice/kgraphicswebslice.cpp 6c976a0f8250e11ffb9dc4e85e122433f86a073a 
  applets/webslice/kwebslice.cpp c1eb9ea8da64129765ad68044f2b7d038387b08b 
  applets/webslice/plasma/webslice.h fbe12420ea372c6f1b073a4f047a6cbb742cc0a0 
  applets/webslice/plasma/webslice.cpp a1740bfd62dd91401a366a240e83e6b84509f81c 
  applets/webslice/plasma/websliceConfig.ui b3ac77608ec66e1be1ebca04488ae19318163a75 

Diff: https://git.reviewboard.kde.org/r/102464/diff/

Testing
-------

Thanks,

Javier Llorente

--===============1985187581824579300==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/102464/">https://git.reviewboard.kde.org/r/102464/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Javier Llorente.</div>

<p style="color: grey;"><i>Updated July 29, 2014, 9:26 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have basically added a function to enable/disable the scrollbar on Web \
Slice.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/webslice/kgraphicswebslice.h <span style="color: \
grey">(dfb60e5b0b3765f8e2324f832f78a1abac0db510)</span></li>

 <li>applets/webslice/kgraphicswebslice.cpp <span style="color: \
grey">(6c976a0f8250e11ffb9dc4e85e122433f86a073a)</span></li>

 <li>applets/webslice/kwebslice.cpp <span style="color: \
grey">(c1eb9ea8da64129765ad68044f2b7d038387b08b)</span></li>

 <li>applets/webslice/plasma/webslice.h <span style="color: \
grey">(fbe12420ea372c6f1b073a4f047a6cbb742cc0a0)</span></li>

 <li>applets/webslice/plasma/webslice.cpp <span style="color: \
grey">(a1740bfd62dd91401a366a240e83e6b84509f81c)</span></li>

 <li>applets/webslice/plasma/websliceConfig.ui <span style="color: \
grey">(b3ac77608ec66e1be1ebca04488ae19318163a75)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/102464/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1985187581824579300==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 