[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 107869: Add a real konquerorsessions plugin for krunner
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-07-29 9:16:53
Message-ID: 20140729091653.15440.82646 () probe ! kde ! org
[Download RAW message or body]
--===============0518148818149279695==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107869/#review63399
-----------------------------------------------------------
The coding style in the entire review is off.
File Attachment: the patch - 0002-Add-a-real-konquerorsessions-plugin_1.patch
<https://git.reviewboard.kde.org//r/107869/#fcomment230>
I don't really understand the whole "kate" comment.
- Vishesh Handa
On Dec. 23, 2012, 12:27 p.m., Jekyll Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/107869/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2012, 12:27 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 188494
> http://bugs.kde.org/show_bug.cgi?id=188494
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> This is a follow-up of https://git.reviewboard.kde.org/r/107868/ .
>
> The code is based upon the old and unreal konquerorsessions plugin, with minimal \
> modification (since I'm not familiar with krunner plugins) to make it work in the \
> way as its name implies.
> The patch can't be uploaded as diff, since it depends upon the patch in \
> https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. See \
> the attached file below.
>
> Diffs
> -----
>
>
> Diff: https://git.reviewboard.kde.org/r/107869/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> the patch
> https://git.reviewboard.kde.org/media/uploaded/files/2012/12/23/0002-Add-a-real-konquerorsessions-plugin_1.patch
>
>
> Thanks,
>
> Jekyll Wu
>
>
--===============0518148818149279695==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/107869/">https://git.reviewboard.kde.org/r/107869/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
coding style in the entire review is off.</p></pre> <br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid \
#c0c0c0; margin-bottom: 10px"> <tr>
<td>
<a href="https://git.reviewboard.kde.org/r/107869/file/296/#source/line165" \
style="color: black; font-weight: bold; font-size: \
9pt;">0002-Add-a-real-konquerorsessions-plugin_1.patch</a>
<p>the patch</p>
<div><table class="sidebyside text-review-ui-table \
text-review-ui-comment-thumbnail "> <colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>165</th>
<td><pre><span class="gi">+ // so everybody else will suffer. And \
rightfully so! ;-)</span></pre></td> </tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't really understand the whole "kate" comment.</p></pre> </div>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On December 23rd, 2012, 12:27 p.m. UTC, Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2012, 12:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=188494">188494</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a follow-up of https://git.reviewboard.kde.org/r/107868/ .
The code is based upon the old and unreal konquerorsessions plugin, with minimal \
modification (since I'm not familiar with krunner plugins) to make it work in the \
way as its name implies.
The patch can't be uploaded as diff, since it depends upon the patch in \
https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. See the \
attached file below.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="https://git.reviewboard.kde.org/r/107869/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2012/12/23/0002-Add-a-real-konquerorsessions-plugin_1.patch">the \
patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0518148818149279695==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic