[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 106978: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2014-07-29 9:27:34
Message-ID: 20140729092734.15440.95032 () probe ! kde ! org
[Download RAW message or body]

--===============5864099715990624853==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106978/
-----------------------------------------------------------

(Updated July 29, 2014, 9:27 a.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Bugs: 225078
    http://bugs.kde.org/show_bug.cgi?id=225078


Repository: kde-workspace


Description
-------

The main issue was caused by the fact that asking the tab bar native widget to \
provide a size hint was giving a different size every time which caused the activity \
bar to expand or shrink in the presence of another expanding widget (in my case, the \
taskbar), so this patch decides a size hint from the size of the containment (one \
third of the width of height depending on the form factor) but the size policy is set \
to expand when the activity bar is the only widget in the containment.


Diffs
-----

  plasma/generic/applets/activitybar/activitybar.cpp e66bf04 

Diff: https://git.reviewboard.kde.org/r/106978/diff/


Testing
-------

1) Add a panel with an actyivity bar and a task bar
2) Add a panel with an activty bar only
3) Change activities

Before this patch, the activity bar in the panel with a task bar shrinks or enlarges \
with every activity change; while the size of the activity bar in the second panel \
remains constant. After this patch, the size of the activity bar in both panels \
remains constant.


Thanks,

David Narváez


--===============5864099715990624853==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/106978/">https://git.reviewboard.kde.org/r/106978/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Narváez.</div>


<p style="color: grey;"><i>Updated July 29, 2014, 9:27 a.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=225078">225078</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The main issue was caused by the fact that asking the tab bar native \
widget to provide a size hint was giving a different size every time which caused the \
activity bar to expand or shrink in the presence of another expanding widget (in my \
case, the taskbar), so this patch decides a size hint from the size of the \
containment (one third of the width of height depending on the form factor) but the \
size policy is set to expand when the activity bar is the only widget in the \
containment.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1) Add a panel with an actyivity bar and a task bar 2) Add a panel with \
an activty bar only 3) Change activities

Before this patch, the activity bar in the panel with a task bar shrinks or enlarges \
with every activity change; while the size of the activity bar in the second panel \
remains constant. After this patch, the size of the activity bar in both panels \
remains constant.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/activitybar/activitybar.cpp <span style="color: \
grey">(e66bf04)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/106978/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============5864099715990624853==--



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic