[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118977: KSMServer: Do not autostart files
From: "Commit Hook" <null () kde ! org>
Date: 2014-07-04 10:01:29
Message-ID: 20140704100129.17149.34231 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118977/#review61592
-----------------------------------------------------------
This review has been submitted with commit f913e251fe66e22606c380a8cc0ddc8c69e3c07d \
by Vishesh Handa to branch master.
- Commit Hook
On July 3, 2014, 12:14 a.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118977/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 12:14 a.m.)
>
>
> Review request for Plasma and Àlex Fiestas.
>
>
> Bugs: 335878
> https://bugs.kde.org/show_bug.cgi?id=335878
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> KSMServer: Do not autostart files
>
> Currently KLauncher is responsible for starting all of the autostart
> files. It intelligently starts only the files which should be started in
> the KDE environment.
>
> Once this is done, KLauncher then decides to also start all the files
> in the autostart folder, but does that without checking which should be
> started. I'm not sure why both KSMServer and KLauncher are overlaping
> and doing the same thing. But it seems that KLauncher is the correct
> place to do this. Specially since ksmserver uses kioclient5 in order to
> start the applications.
>
> BUG: 335878
>
>
> Diffs
> -----
>
> ksmserver/server.h 3d19118
> ksmserver/startup.cpp 11cc968
>
> Diff: https://git.reviewboard.kde.org/r/118977/diff/
>
>
> Testing
> -------
>
> Applications are now only started once.
>
>
> Thanks,
>
> Vishesh Handa
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118977/">https://git.reviewboard.kde.org/r/118977/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f913e251fe66e22606c380a8cc0ddc8c69e3c07d by Vishesh Handa to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On July 3rd, 2014, 12:14 a.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Àlex Fiestas.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated July 3, 2014, 12:14 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=335878">335878</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> KSMServer: Do not autostart files
Currently KLauncher is responsible for starting all of the autostart
files. It intelligently starts only the files which should be started in
the KDE environment.
Once this is done, KLauncher then decides to also start all the files
in the autostart folder, but does that without checking which should be
started. I'm not sure why both KSMServer and KLauncher are overlaping
and doing the same thing. But it seems that KLauncher is the correct
place to do this. Specially since ksmserver uses kioclient5 in order to
start the applications.
BUG: 335878
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Applications are now only started once.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/server.h <span style="color: grey">(3d19118)</span></li>
<li>ksmserver/startup.cpp <span style="color: grey">(11cc968)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118977/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic