'Re: Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES
From:       "Commit Hook" <null () kde ! org>
Date:       2014-07-04 10:01:30
Message-ID: 20140704100130.6931.11297 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119103/#review61594
-----------------------------------------------------------

This review has been submitted with commit 7a6ef7aaf9cc32173ea61b4f71c802da5c6ac3d2 \
by Vishesh Handa to branch master.

- Commit Hook

On July 3, 2014, 11:25 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119103/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 11:25 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Startkde: Remove KLOCALE_LANGUAGES
> 
> KLOCALE_LANGUAGES was used by the kde4 ksplash in order to to know which
> language to show. This environment variable is no longer used by the qml
> based ksplash. It makes no sense to have it.
> 
> Additionally, this means we can stop linking against kdelibs4support.
> This is important cause kdostartupconfig blocks the rest of the boot
> sequence. On my system it causes a good 0.3 - 0.4 seconds delay. By no
> longer linking to kdelibs4support it takes less than 0.1 seconds and no
> longer shows up in the bootchat logs.
> 
> 
> Diffs
> -----
> 
> startkde/kstartupconfig/CMakeLists.txt 6920fe5 
> startkde/kstartupconfig/kdostartupconfig.cpp d545f4f 
> startkde/startkde.cmake 40e3377 
> 
> Diff: https://git.reviewboard.kde.org/r/119103/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119103/">https://git.reviewboard.kde.org/r/119103/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 7a6ef7aaf9cc32173ea61b4f71c802da5c6ac3d2 by Vishesh Handa to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On July 3rd, 2014, 11:25 a.m. UTC, Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated July 3, 2014, 11:25 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    Startkde: Remove KLOCALE_LANGUAGES

    KLOCALE_LANGUAGES was used by the kde4 ksplash in order to to know which
    language to show. This environment variable is no longer used by the qml
    based ksplash. It makes no sense to have it.

    Additionally, this means we can stop linking against kdelibs4support.
    This is important cause kdostartupconfig blocks the rest of the boot
    sequence. On my system it causes a good 0.3 - 0.4 seconds delay. By no
    longer linking to kdelibs4support it takes less than 0.1 seconds and no
    longer shows up in the bootchat logs.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>startkde/kstartupconfig/CMakeLists.txt <span style="color: \
grey">(6920fe5)</span></li>

 <li>startkde/kstartupconfig/kdostartupconfig.cpp <span style="color: \
grey">(d545f4f)</span></li>

 <li>startkde/startkde.cmake <span style="color: grey">(40e3377)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119103/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 