'Re: Review Request 119105: PlasmaShell: Disable Session Management'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119105: PlasmaShell: Disable Session Management
From:       "Commit Hook" <null () kde ! org>
Date:       2014-07-04 10:01:29
Message-ID: 20140704100129.17149.51197 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119105/#review61593
-----------------------------------------------------------

This review has been submitted with commit 7652d581921c355135be41ec205d85b1d21c1590 \
by Vishesh Handa to branch master.

- Commit Hook

On July 3, 2014, 3:42 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119105/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 3:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> PlasmaShell: Disable Session Management
> 
> PlasmaShell should not be restored by the session manager. It will be
> started by klauncher because we install an autostart file.
> 
> This also clears up the booting process to a certain extent, as
> plasmashell will now not be started twice (once via session restore, and
> once via autostart)
> 
> 
> Diffs
> -----
> 
> shell/main.cpp 0b96674 
> 
> Diff: https://git.reviewboard.kde.org/r/119105/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119105/">https://git.reviewboard.kde.org/r/119105/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 7652d581921c355135be41ec205d85b1d21c1590 by Vishesh Handa to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On July 3rd, 2014, 3:42 p.m. UTC, Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated July 3, 2014, 3:42 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    PlasmaShell: Disable Session Management

    PlasmaShell should not be restored by the session manager. It will be
    started by klauncher because we install an autostart file.

    This also clears up the booting process to a certain extent, as
    plasmashell will now not be started twice (once via session restore, and
    once via autostart)
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/main.cpp <span style="color: grey">(0b96674)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119105/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 