'Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.
From:       Ivan Čukić <ivan.cukic () kde ! org>
Date:       2014-05-31 21:32:09
Message-ID: 20140531213209.27320.41633 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118340/#review58867
-----------------------------------------------------------

Ship it!

I don't have anything against the patch, except that it is a bit different to what \
the kf5 version (master) has.

Master checks for the option called KACTIVITIES_LIBRARY_ONLY.

If it is not a bother, can you rename the option in 4.13 to match it - to avoid \
confusion.

- Ivan Čukić

On May 31, 2014, 3:42 a.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118340/
> -----------------------------------------------------------
> 
> (Updated May 31, 2014, 3:42 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> To allow for the library to be co-installed with the frameworks version, allow the \
> daemon to be disabled. 
> I'm not sure if this is the best way to do this.  If there is any better way, I'll \
> update the patch as appropriate. 
> 
> Diffs
> -----
> 
> src/CMakeLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9 
> 
> Diff: https://git.reviewboard.kde.org/r/118340/diff/
> 
> 
> Testing
> -------
> 
> Visually inspected install directories.  Seems to remove only what is necessary.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118340/">https://git.reviewboard.kde.org/r/118340/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don&#39;t have \
anything against the patch, except that it is a bit different to what the kf5 version \
(master) has.

Master checks for the option called KACTIVITIES_LIBRARY_ONLY.

If it is not a bother, can you rename the option in 4.13 to match it - to avoid \
confusion.</pre>  <br />

<p>- Ivan Čukić</p>

<br />
<p>On May 31st, 2014, 3:42 a.m. UTC, Matthew Dawson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Plasma and Ivan Čukić.</div>
<div>By Matthew Dawson.</div>

<p style="color: grey;"><i>Updated May 31, 2014, 3:42 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kactivities
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To allow for the library to be co-installed with the frameworks version, \
allow the daemon to be disabled.

I&#39;m not sure if this is the best way to do this.  If there is any better way, \
I&#39;ll update the patch as appropriate.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Visually inspected install directories.  Seems to remove only what is \
necessary.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: \
grey">(b4733648fd53ebd681694f185cc5b23f51dfd3f9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118340/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 