This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ |
Ship it!
I don't have anything against the patch, except that it is a bit different to what the kf5 version (master) has. Master checks for the option called KACTIVITIES_LIBRARY_ONLY. If it is not a bother, can you rename the option in 4.13 to match it - to avoid confusion.
- Ivan Čukić
On May 31st, 2014, 3:42 a.m. UTC, Matthew Dawson wrote:
Review request for KDE Frameworks, Plasma and Ivan Čukić.
By Matthew Dawson.
Updated May 31, 2014, 3:42 a.m.
Repository:
kactivities
Description
Testing
Diffs
|