From kde-panel-devel Sat May 31 21:32:09 2014 From: =?utf-8?b?SXZhbiDEjHVracSH?= Date: Sat, 31 May 2014 21:32:09 +0000 To: kde-panel-devel Subject: Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled. Message-Id: <20140531213209.27320.41633 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140157196104007 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7497617423294835578==" --===============7497617423294835578== Content-Type: multipart/alternative; boundary="===============3025533839554326385==" --===============3025533839554326385== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58867 ----------------------------------------------------------- Ship it! I don't have anything against the patch, except that it is a bit different to what the kf5 version (master) has. Master checks for the option called KACTIVITIES_LIBRARY_ONLY. If it is not a bother, can you rename the option in 4.13 to match it - to avoid confusion. - Ivan Čukić On May 31, 2014, 3:42 a.m., Matthew Dawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118340/ > ----------------------------------------------------------- > > (Updated May 31, 2014, 3:42 a.m.) > > > Review request for KDE Frameworks, Plasma and Ivan Čukić. > > > Repository: kactivities > > > Description > ------- > > To allow for the library to be co-installed with the frameworks version, allow the daemon to be disabled. > > I'm not sure if this is the best way to do this. If there is any better way, I'll update the patch as appropriate. > > > Diffs > ----- > > src/CMakeLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9 > > Diff: https://git.reviewboard.kde.org/r/118340/diff/ > > > Testing > ------- > > Visually inspected install directories. Seems to remove only what is necessary. > > > Thanks, > > Matthew Dawson > > --===============3025533839554326385== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/

Ship it!

I don't have anything against the patch, except that it is a bit different to what the kf5 version (master) has.

Master checks for the option called KACTIVITIES_LIBRARY_ONLY.

If it is not a bother, can you rename the option in 4.13 to match it - to avoid confusion.

- Ivan Čukić

On May 31st, 2014, 3:42 a.m. UTC, Matthew Dawson wrote:

Review request for KDE Frameworks, Plasma and Ivan Čukić.

By Matthew Dawson.

Updated May 31, 2014, 3:42 a.m.

Repository: kactivities

Description

To allow for the library to be co-installed with the frameworks version, allow the daemon to be disabled.

I'm not sure if this is the best way to do this.  If there is any better way, I'll update the patch as appropriate.

Testing

Visually inspected install directories.  Seems to remove only what is necessary.

Diffs

src/CMakeLists.txt (b4733648fd53ebd681694f185cc5b23f51dfd3f9)

--===============3025533839554326385==-- --===============7497617423294835578== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7497617423294835578==--