[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118388: rename systemsettings binary to systemsettings5
From: "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date: 2014-05-29 16:25:42
Message-ID: 20140529162542.14701.1298 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 29, 2014, 9:10 a.m., Ben Cooksley wrote:
> > Code wise, this change looks fine. In terms of renaming the desktop files - i'm \
> > fine with changing the filenames, but please don't change the name of the \
> > application itself. Ideally the KF5 based system settings will still be able to \
> > set configuration details relevant for KDE 4 applications.
> Ideally the KF5 based system settings will still be able to set configuration \
> details relevant for KDE 4 applications.
that sounds great to me - just that it would need work in every kcm module. \
additional caveats: what if there's only 4.x variant of the kcm?
an option is removed in KF5 variant?
most importantly - how to implement it (different config locations, etc)? =)
- Hrvoje
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118388/#review58690
-----------------------------------------------------------
On May 28, 2014, 9:32 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118388/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 9:32 p.m.)
>
>
> Review request for Plasma and Ben Cooksley.
>
>
> Repository: systemsettings
>
>
> Description
> -------
>
> while workspace might not be targeted to co-exist with 4.x variant - systemsettings \
> should IMHO be able to co-exist. not only workspace components are adjusting in \
> there, and telling people to do kcmshell$notinstalledvariant $wantedkcm is very \
> user-unfriendly... one TODO if this gets a green light, is to rename desktop files, \
> so people know which variant they are opening.
>
> Diffs
> -----
>
> app/systemsettings.desktop 5f27318
> app/kdesystemsettings.desktop 946d498
> app/CMakeLists.txt c45f7e7
>
> Diff: https://git.reviewboard.kde.org/r/118388/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118388/">https://git.reviewboard.kde.org/r/118388/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 29th, 2014, 9:10 a.m. CEST, <b>Ben \
Cooksley</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Code wise, this change looks fine. In terms of renaming the desktop \
files - i'm fine with changing the filenames, but please don't change the \
name of the application itself. Ideally the KF5 based system settings will still be \
able to set configuration details relevant for KDE 4 applications.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>Ideally the KF5 \
based system settings will still be able to set configuration details relevant for \
KDE 4 applications.
that sounds great to me - just that it would need work in every kcm module. \
additional caveats: what if there's only 4.x variant of the kcm?
an option is removed in KF5 variant?
most importantly - how to implement it (different config locations, etc)? =) </pre>
<br />
<p>- Hrvoje</p>
<br />
<p>On May 28th, 2014, 9:32 p.m. CEST, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Ben Cooksley.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated May 28, 2014, 9:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
systemsettings
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">while workspace might not be targeted to co-exist with 4.x variant - \
systemsettings should IMHO be able to co-exist. not only workspace components are \
adjusting in there, and telling people to do kcmshell$notinstalledvariant $wantedkcm \
is very user-unfriendly... one TODO if this gets a green light, is to rename desktop \
files, so people know which variant they are opening.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/systemsettings.desktop <span style="color: grey">(5f27318)</span></li>
<li>app/kdesystemsettings.desktop <span style="color: grey">(946d498)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(c45f7e7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118388/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic