This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118388/ |
On May 29th, 2014, 9:10 a.m. CEST, Ben Cooksley wrote:
Code wise, this change looks fine. In terms of renaming the desktop files - i'm fine with changing the filenames, but please don't change the name of the application itself. Ideally the KF5 based system settings will still be able to set configuration details relevant for KDE 4 applications.
>Ideally the KF5 based system settings will still be able to set configuration details relevant for KDE 4 applications. that sounds great to me - just that it would need work in every kcm module. additional caveats: what if there's only 4.x variant of the kcm? an option is removed in KF5 variant? most importantly - how to implement it (different config locations, etc)? =)
- Hrvoje
On May 28th, 2014, 9:32 p.m. CEST, Hrvoje Senjan wrote:
Review request for Plasma and Ben Cooksley.
By Hrvoje Senjan.
Updated May 28, 2014, 9:32 p.m.
Repository:
systemsettings
Description
Diffs
|