--===============4758146052968325334== Content-Type: multipart/alternative; boundary="===============7368877126749233636==" --===============7368877126749233636== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On May 29, 2014, 9:10 a.m., Ben Cooksley wrote: > > Code wise, this change looks fine. In terms of renaming the desktop files - i'm fine with changing the filenames, but please don't change the name of the application itself. Ideally the KF5 based system settings will still be able to set configuration details relevant for KDE 4 applications. >Ideally the KF5 based system settings will still be able to set configuration details relevant for KDE 4 applications. that sounds great to me - just that it would need work in every kcm module. additional caveats: what if there's only 4.x variant of the kcm? an option is removed in KF5 variant? most importantly - how to implement it (different config locations, etc)? =) - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118388/#review58690 ----------------------------------------------------------- On May 28, 2014, 9:32 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118388/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 9:32 p.m.) > > > Review request for Plasma and Ben Cooksley. > > > Repository: systemsettings > > > Description > ------- > > while workspace might not be targeted to co-exist with 4.x variant - systemsettings should IMHO be able to co-exist. not only workspace components are adjusting in there, and telling people to do kcmshell$notinstalledvariant $wantedkcm is very user-unfriendly... > one TODO if this gets a green light, is to rename desktop files, so people know which variant they are opening. > > > Diffs > ----- > > app/systemsettings.desktop 5f27318 > app/kdesystemsettings.desktop 946d498 > app/CMakeLists.txt c45f7e7 > > Diff: https://git.reviewboard.kde.org/r/118388/diff/ > > > Testing > ------- > > > Thanks, > > Hrvoje Senjan > > --===============7368877126749233636== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118388/

On May 29th, 2014, 9:10 a.m. CEST, Ben Cooksley wrote:

Code wise, this change looks fine. In terms of renaming the desktop files - i'm fine with changing the filenames, but please don't change the name of the application itself. Ideally the KF5 based system settings will still be able to set configuration details relevant for KDE 4 applications.

>Ideally the KF5 based system settings will still be able to set configuration details relevant for KDE 4 applications.

that sounds great to me - just that it would need work in every kcm module. additional caveats:
what if there's only 4.x variant of the kcm?
an option is removed in KF5 variant?
most importantly - how to implement it (different config locations, etc)? =)

- Hrvoje

On May 28th, 2014, 9:32 p.m. CEST, Hrvoje Senjan wrote:

Review request for Plasma and Ben Cooksley.

By Hrvoje Senjan.

Updated May 28, 2014, 9:32 p.m.

Repository: systemsettings

Description

while workspace might not be targeted to co-exist with 4.x variant - systemsettings should IMHO be able to co-exist. not only workspace components are adjusting in there, and telling people to do kcmshell$notinstalledvariant $wantedkcm is very user-unfriendly...
one TODO if this gets a green light, is to rename desktop files, so people know which variant they are opening.

Diffs

app/systemsettings.desktop (5f27318)
app/kdesystemsettings.desktop (946d498)
app/CMakeLists.txt (c45f7e7)

--===============7368877126749233636==-- --===============4758146052968325334== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4758146052968325334==--