'Review Request 117893: Add unit test for kscreenlocker_greet to test all signals'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 117893: Add unit test for kscreenlocker_greet to test all signals
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-04-30 9:19:32
Message-ID: 20140430091932.1393.91098 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117893/
-----------------------------------------------------------

Review request for Plasma, David Edmundson and Wolfgang Bauer.

Repository: plasma-workspace

Description
-------

Add unit test for kscreenlocker_greet to test all signals

The idea behind this unit test is to verify that no matter which signal
is sent to the greeter it doesn't return an exit code of 0 which would
indicate a successful authentication.

The test starts the greeter (needs to be installed) and waits 5 sec to
make sure that the greeter is really up and running. If the signal is
sent to early it's causing a CrashExit, which is fine but not the
expected result. There's an additional test to verify that the early sent
signal results in CrashExit.

Diffs
-----

  ksmserver/screenlocker/greeter/autotests/CMakeLists.txt f7ebde0c576ee41c82f1854190c1f160c47f3229 
  ksmserver/screenlocker/greeter/autotests/killtest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117893/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117893/">https://git.reviewboard.kde.org/r/117893/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, David Edmundson and Wolfgang Bauer.</div>
<div>By Martin Gräßlin.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add unit test for kscreenlocker_greet to test all signals

The idea behind this unit test is to verify that no matter which signal
is sent to the greeter it doesn&#39;t return an exit code of 0 which would
indicate a successful authentication.

The test starts the greeter (needs to be installed) and waits 5 sec to
make sure that the greeter is really up and running. If the signal is
sent to early it&#39;s causing a CrashExit, which is fine but not the
expected result. There&#39;s an additional test to verify that the early sent
signal results in CrashExit.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/greeter/autotests/CMakeLists.txt <span style="color: \
grey">(f7ebde0c576ee41c82f1854190c1f160c47f3229)</span></li>

 <li>ksmserver/screenlocker/greeter/autotests/killtest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117893/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 