--===============6362575631327574995== Content-Type: multipart/alternative; boundary="===============0525092143427660293==" --===============0525092143427660293== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117893/ ----------------------------------------------------------- Review request for Plasma, David Edmundson and Wolfgang Bauer. Repository: plasma-workspace Description ------- Add unit test for kscreenlocker_greet to test all signals The idea behind this unit test is to verify that no matter which signal is sent to the greeter it doesn't return an exit code of 0 which would indicate a successful authentication. The test starts the greeter (needs to be installed) and waits 5 sec to make sure that the greeter is really up and running. If the signal is sent to early it's causing a CrashExit, which is fine but not the expected result. There's an additional test to verify that the early sent signal results in CrashExit. Diffs ----- ksmserver/screenlocker/greeter/autotests/CMakeLists.txt f7ebde0c576ee41c82f1854190c1f160c47f3229 ksmserver/screenlocker/greeter/autotests/killtest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117893/diff/ Testing ------- Thanks, Martin Gräßlin --===============0525092143427660293== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117893/

Review request for Plasma, David Edmundson and Wolfgang Bauer.
By Martin Gräßlin.
Repository: plasma-workspace

Description 

Add unit test for kscreenlocker_greet to test all signals

The idea behind this unit test is to verify that no matter which signal
is sent to the greeter it doesn't return an exit code of 0 which would
indicate a successful authentication.

The test starts the greeter (needs to be installed) and waits 5 sec to
make sure that the greeter is really up and running. If the signal is
sent to early it's causing a CrashExit, which is fine but not the
expected result. There's an additional test to verify that the early sent
signal results in CrashExit.

Diffs

  • ksmserver/screenlocker/greeter/autotests/CMakeLists.txt (f7ebde0c576ee41c82f1854190c1f160c47f3229)
  • ksmserver/screenlocker/greeter/autotests/killtest.cpp (PRE-CREATION)

View Diff
--===============0525092143427660293==-- --===============6362575631327574995== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6362575631327574995==--