'Re: Review Request 117891: Fix x/y property values in DeclarativeDragDropEvent'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117891: Fix x/y property values in DeclarativeDragDropEvent
From:       "Eike Hein" <hein () kde ! org>
Date:       2014-04-30 9:08:54
Message-ID: 20140430090854.27257.873 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117891/
-----------------------------------------------------------

(Updated April 30, 2014, 9:08 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Marco Martin.

Repository: kdeclarative

Description
-------

DeclarativeDragDropEvent runs the coordinates it gets from QQuickItem::dragMoveEvent \
through mapFromScene(), which is unnecessary - the coordinates are already in the \
item's reference frame - and actually causes them to be wrong when a \
DeclarativeDropArea isn't at QPoint(0,0) in the scene.

Diffs
-----

  src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp 374a09b 

Diff: https://git.reviewboard.kde.org/r/117891/diff/

Testing
-------

Thanks,

Eike Hein

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117891/">https://git.reviewboard.kde.org/r/117891/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Eike Hein.</div>

<p style="color: grey;"><i>Updated April 30, 2014, 9:08 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">DeclarativeDragDropEvent runs the coordinates it gets from \
QQuickItem::dragMoveEvent through mapFromScene(), which is unnecessary - the \
coordinates are already in the item&#39;s reference frame - and actually causes them \
to be wrong when a DeclarativeDropArea isn&#39;t at QPoint(0,0) in the scene.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp <span style="color: \
grey">(374a09b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117891/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 