From kde-panel-devel Wed Apr 30 09:08:54 2014 From: "Eike Hein" Date: Wed, 30 Apr 2014 09:08:54 +0000 To: kde-panel-devel Subject: Re: Review Request 117891: Fix x/y property values in DeclarativeDragDropEvent Message-Id: <20140430090854.27257.873 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139884895417268 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7776532637184686624==" --===============7776532637184686624== Content-Type: multipart/alternative; boundary="===============3156505742112153579==" --===============3156505742112153579== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117891/ ----------------------------------------------------------- (Updated April 30, 2014, 9:08 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Marco Martin. Repository: kdeclarative Description ------- DeclarativeDragDropEvent runs the coordinates it gets from QQuickItem::dragMoveEvent through mapFromScene(), which is unnecessary - the coordinates are already in the item's reference frame - and actually causes them to be wrong when a DeclarativeDropArea isn't at QPoint(0,0) in the scene. Diffs ----- src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp 374a09b Diff: https://git.reviewboard.kde.org/r/117891/diff/ Testing ------- Thanks, Eike Hein --===============3156505742112153579== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117891/

This change has been marked as submitted.

Review request for Plasma and Marco Martin.

By Eike Hein.

Updated April 30, 2014, 9:08 a.m.

Repository: kdeclarative

Description

DeclarativeDragDropEvent runs the coordinates it gets from QQuickItem::dragMoveEvent through mapFromScene(), which is unnecessary - the coordinates are already in the item's reference frame - and actually causes them to be wrong when a DeclarativeDropArea isn't at QPoint(0,0) in the scene.

Diffs

src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp (374a09b)

View Diff

--===============3156505742112153579==-- --===============7776532637184686624== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7776532637184686624==--