[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 115409: Workaround battery detection at runtime
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2014-03-26 12:12:02
Message-ID: 20140326121202.27691.17208 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 7, 2014, 12:19 p.m., Christoph Feck wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 75
> > <https://git.reviewboard.kde.org/r/115409/diff/1/?file=241087#file241087line75>
> >
> > Removal of this causes two other regressions: bug 331797, bug 331831.
> >
> > I re-added the "onDataChanged:" handling and both bugs are gone, but I only have \
> > a single battery, so I cannot test if bug 324847 is still fixed.
>
> Kai Uwe Broulik wrote:
> Sorry for the inconvenience :-(
>
> Will try to test your patch [1] tomorrow.
>
> [1] http://bugsfiles.kde.org/attachment.cgi?id=85464
>
>
> Christoph Feck wrote:
> Don't worry :) The regressions are minor, and to be honest, I would prefer to not \
> commit my patch, unless we find a way to get both bug 321823 and the regressions \
> fixed.
> Kai Uwe Broulik wrote:
> Just tested it, plugged in and out my mouse multiple times and it appears and \
> re-appears, and also the tooltip (which is reported broken in Bug 324847 Comment \
> 19) seems properly updated.
> Go ahead and push it, thanks for taking care of this! :-)
>
> Christoph Feck wrote:
> But then we would get bug 321823 again...
I think showing wrong brightness (0%) is worse than the auto-closing popup with Ac \
plugged in and battery charged and the thing hidden in the popup. I'm seeing a lot of \
posts about this regression on G+ and other sources lately. So, please push. :/
Plasma Next should fix the Bug 321823 for us at least I guess.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115409/#review52338
-----------------------------------------------------------
On Feb. 15, 2014, 10:19 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115409/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2014, 10:19 p.m.)
>
>
> Review request for Plasma, Solid and Sebastian Kügler.
>
>
> Bugs: 324847
> http://bugs.kde.org/show_bug.cgi?id=324847
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> For some reason when a new battery appears (eg. mouse plugged in), the battery does \
> not appear right away in the battery monitor. It appears instantly in \
> plasmaengineexplorer, however. I am really clueless on to what causes this, so I \
> just throw this patch in for enlightenment as it sort of makes it work. :/
>
> Diffs
> -----
>
> plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml c1c0169
>
> Diff: https://git.reviewboard.kde.org/r/115409/diff/
>
>
> Testing
> -------
>
> Has some minor glitches, please see bugreport.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115409/">https://git.reviewboard.kde.org/r/115409/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 7th, 2014, 12:19 p.m. UTC, <b>Christoph \
Feck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115409/diff/1/?file=241087#file241087line75" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">75</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">onDataChanged:</span> <span class="p">{</span></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removal of this causes \
two other regressions: bug 331797, bug 331831.
I re-added the "onDataChanged:" handling and both bugs are gone, but I only \
have a single battery, so I cannot test if bug 324847 is still fixed.</pre> \
</blockquote>
<p>On March 7th, 2014, 3:38 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for the \
inconvenience :-(
Will try to test your patch [1] tomorrow.
[1] http://bugsfiles.kde.org/attachment.cgi?id=85464
</pre>
</blockquote>
<p>On March 7th, 2014, 6:48 p.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't worry :) The \
regressions are minor, and to be honest, I would prefer to not commit my patch, \
unless we find a way to get both bug 321823 and the regressions fixed.</pre> \
</blockquote>
<p>On March 10th, 2014, 6:23 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just tested it, plugged \
in and out my mouse multiple times and it appears and re-appears, and also the \
tooltip (which is reported broken in Bug 324847 Comment 19) seems properly updated.
Go ahead and push it, thanks for taking care of this! :-)</pre>
</blockquote>
<p>On March 11th, 2014, 12:15 a.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But then we would get \
bug 321823 again...</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think \
showing wrong brightness (0%) is worse than the auto-closing popup with Ac plugged in \
and battery charged and the thing hidden in the popup. I'm seeing a lot of posts \
about this regression on G+ and other sources lately. So, please push. :/
Plasma Next should fix the Bug 321823 for us at least I guess.</pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On February 15th, 2014, 10:19 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Solid and Sebastian Kügler.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2014, 10:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=324847">324847</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For some reason when a new battery appears (eg. mouse plugged in), the \
battery does not appear right away in the battery monitor. It appears instantly in \
plasmaengineexplorer, however. I am really clueless on to what causes this, so I just \
throw this patch in for enlightenment as it sort of makes it work. :/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Has some minor glitches, please see bugreport.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml <span \
style="color: grey">(c1c0169)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115409/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic